Re-enable some tests that it seems should work now

mshinwell · mshinwell · commit 517e63c477ea · 2023-11-30T18:02:26.000Z
diff --git a/ocaml/testsuite/tests/c-api/test_c_thread_has_lock.ml b/ocaml/testsuite/tests/c-api/test_c_thread_has_lock.ml
@@ -1,9 +1,7 @@
 (* TEST
    modules = "test_c_thread_has_lock_cstubs.c"
-   * skip
-   reason = "OCaml 5 only"
-   ** bytecode
-   ** native
+   * bytecode
+   * native
 *)
 
 external test_with_lock : unit -> bool = "with_lock"
diff --git a/ocaml/testsuite/tests/c-api/test_c_thread_has_lock_systhread.ml b/ocaml/testsuite/tests/c-api/test_c_thread_has_lock_systhread.ml
@@ -1,11 +1,9 @@
 (* TEST
    modules = "test_c_thread_has_lock_cstubs.c"
-   * skip
-   reason = "OCaml 5 only"
-   ** hassysthreads
+   * hassysthreads
    include systhreads
-   *** bytecode
-   *** native
+   ** bytecode
+   ** native
 *)
 
 external test_with_lock : unit -> bool = "with_lock"
diff --git a/ocaml/testsuite/tests/frame-pointers/c_call.ml b/ocaml/testsuite/tests/frame-pointers/c_call.ml
@@ -1,9 +1,7 @@
 (* TEST
 
-* skip
-reason = "OCaml 5 only"
-** frame_pointers
-*** native
+* frame_pointers
+** native
 readonly_files = "fp_backtrace.c c_call_.c"
 all_modules = "${readonly_files} c_call.ml"
 
diff --git a/ocaml/testsuite/tests/frame-pointers/exception_handler.ml b/ocaml/testsuite/tests/frame-pointers/exception_handler.ml
@@ -1,9 +1,7 @@
 (* TEST
 
-* skip
-reason = "OCaml 5 only"
-** frame_pointers
-*** native
+* frame_pointers
+** native
 readonly_files = "fp_backtrace.c"
 all_modules = "${readonly_files} exception_handler.ml"
 
diff --git a/ocaml/testsuite/tests/lazy/minor_major_force.ml b/ocaml/testsuite/tests/lazy/minor_major_force.ml
@@ -1,8 +1,5 @@
 (* TEST
    ocamlopt_flags += " -O3 "
-
-   * skip
-     reason = "OCaml 5 only"
 *)
 
 (*
diff --git a/ocaml/testsuite/tests/lf_skiplist/test.ml b/ocaml/testsuite/tests/lf_skiplist/test.ml
@@ -1,8 +1,5 @@
 (* TEST
    modules = "stubs.c"
-
-   * skip
-     reason = "OCaml 5 only"
 *)
 
 external test_skiplist_serial : unit -> unit = "test_skiplist_serial"
diff --git a/ocaml/testsuite/tests/lib-channels/close_in.ml b/ocaml/testsuite/tests/lib-channels/close_in.ml
@@ -1,7 +1,4 @@
-(* TEST
-* skip
-reason = "OCaml 5 only"
- *)
+(* TEST *)
 
 (* Test that inputting bytes from a closed in_channel triggers an exception *)
 
diff --git a/ocaml/testsuite/tests/lib-random/testvectors.ml b/ocaml/testsuite/tests/lib-random/testvectors.ml
@@ -1,6 +1,4 @@
 (* TEST
- * skip
-   reason = "OCaml 5 only"
 *)
 
 (* Check the numbers drawn from a known state against the numbers
diff --git a/ocaml/testsuite/tests/lib-sync/trylock.ml b/ocaml/testsuite/tests/lib-sync/trylock.ml
@@ -1,6 +1,4 @@
 (* TEST
- * skip
-   reason = "OCaml 5 only"
 *)
 
 (* Test Mutex.try_lock *)
diff --git a/ocaml/testsuite/tests/lib-sync/trylock2.ml b/ocaml/testsuite/tests/lib-sync/trylock2.ml
@@ -1,6 +1,4 @@
 (* TEST
- * skip
-   reason = "OCaml 5 only"
 *)
 
 (* Test Mutex.try_lock *)
diff --git a/ocaml/testsuite/tests/lib-systhreads/boundscheck.ml b/ocaml/testsuite/tests/lib-systhreads/boundscheck.ml
@@ -1,11 +1,9 @@
 (* TEST
 
 include systhreads
-* skip
-reason = "OCaml 5 only"
-** hassysthreads
-*** bytecode
-*** native
+* hassysthreads
+** bytecode
+** native
 
 *)
 
diff --git a/ocaml/testsuite/tests/memory-model/forbidden.ml b/ocaml/testsuite/tests/memory-model/forbidden.ml
@@ -1,7 +1,7 @@
 (* TEST
   modules="opt.ml barrier.ml hist.ml shared.ml run.ml outcome.ml"
   * skip
-  reason = "OCaml 5 only"
+  reason = "CR ocaml 5 domains: re-enable this test"
   ** not-bsd
   *** bytecode
   *** native

-Original file line number
+Diff line change
@@ @@ -1,8 +1,5 @@ @@
 (* TEST
    ocamlopt_flags += " -O3 "
+-
 -   * skip
 -     reason = "OCaml 5 only"
 *)
 (*