flambda-backend: Tweak lib-threads/sockets.ml (flaky test) (#2544)

* Collect lines and print them at the end.

* Protect reference access.

Author: xclerc

testsuite/tests/lib-threads/sockets.ml

@@ -27,16 +27,21 @@ let server sock =
     ignore(Thread.create serve_connection s)
   done
 
+let mutex = Mutex.create ()
+let lines = ref []
+
 let client (addr, msg) =
   let sock =
     Unix.socket (Unix.domain_of_sockaddr addr) Unix.SOCK_STREAM 0 in
   Unix.connect sock addr;
   let buf = Bytes.make 1024 ' ' in
   ignore(Unix.write_substring sock msg 0 (String.length msg));
   let n = Unix.read sock buf 0 (Bytes.length buf) in
-  print_bytes (Bytes.sub buf 0 n); flush stdout
+  Mutex.lock mutex;
+  lines := (Bytes.sub buf 0 n) :: !lines;
+  Mutex.unlock mutex
 
-let _ =
+let () =
   let addr = Unix.ADDR_INET(Unix.inet_addr_loopback, 0) in
   let sock =
     Unix.socket (Unix.domain_of_sockaddr addr) Unix.SOCK_STREAM 0 in
@@ -45,6 +50,9 @@ let _ =
   let addr = Unix.getsockname sock in
   Unix.listen sock 5;
   ignore (Thread.create server sock);
-  ignore (Thread.create client (addr, "Client #1\n"));
+  let client1 = Thread.create client (addr, "Client #1\n") in
   Thread.delay 0.05;
-  client (addr, "Client #2\n")
+  client (addr, "Client #2\n");
+  Thread.join client1;
+  List.iter print_bytes (List.sort Bytes.compare !lines);
+  flush stdout