Skip to content

Commit aea000f

Browse files
authored
Move mixed blocks from layouts_alpha to layouts_beta (#2542)
1 parent 194c899 commit aea000f

29 files changed

+812
-1187
lines changed

ocaml/testsuite/tests/mixed-blocks/constructor_args.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(* TEST
2-
flags = "-extension layouts_alpha";
2+
flags = "-extension layouts_beta";
33
flambda2;
44
{
55
native;

ocaml/testsuite/tests/mixed-blocks/generate_mixed_blocks_code.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ let main n ~bytecode =
558558
List.iter2 values (List.tl values @ [ List.hd values]) ~f
559559
in
560560
line {|(* TEST
561-
flags = "-extension layouts_alpha";|};
561+
flags = "-extension layouts_beta";|};
562562
if bytecode then (
563563
line {| bytecode;|};
564564
) else (

ocaml/testsuite/tests/mixed-blocks/generated_byte_test.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(* TEST
2-
flags = "-extension layouts_alpha";
2+
flags = "-extension layouts_beta";
33
bytecode;
44
*)
55
(** This is code generated by [generate_mixed_blocks_code.ml]. *)

ocaml/testsuite/tests/mixed-blocks/generated_native_test.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(* TEST
2-
flags = "-extension layouts_alpha";
2+
flags = "-extension layouts_beta";
33
flambda2;
44
native;
55
*)

ocaml/testsuite/tests/mixed-blocks/hash.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(* TEST
2-
flags = "-extension layouts_alpha";
2+
flags = "-extension layouts_beta";
33
flambda2;
44
{
55
native;

ocaml/testsuite/tests/mixed-blocks/recursive_mixed_blocks.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(* TEST
2-
flags = "-extension layouts_alpha";
2+
flags = "-extension layouts_beta";
33
flambda2;
44
{
55
native;

ocaml/testsuite/tests/mixed-blocks/test_mixed_blocks.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
(* TEST
22
flambda2;
33
{
4-
flags = "-extension layouts_alpha";
4+
flags = "-extension layouts_beta";
55
native;
66
}{
7-
flags = "-extension layouts_alpha";
7+
flags = "-extension layouts_beta";
88
bytecode;
99
}
1010
*)

ocaml/testsuite/tests/mixed-blocks/test_printing.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(* TEST
2-
flags = "-extension layouts_alpha";
2+
flags = "-extension layouts_beta";
33
expect;
44
*)
55

ocaml/testsuite/tests/mixed-blocks/typing_recursive_mixed_blocks.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
(* TEST
2-
flags = "-extension layouts_alpha";
2+
flags = "-extension layouts_beta";
33
expect;
44
*)
55

ocaml/testsuite/tests/typing-layouts-bits32/basics_alpha.ml

Lines changed: 0 additions & 97 deletions
This file was deleted.

ocaml/testsuite/tests/typing-layouts-bits32/basics_beta.ml

Lines changed: 16 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
(* TEST
2-
flags = "-extension layouts_beta";
3-
expect;
2+
{
3+
flags = "-extension layouts_alpha";
4+
expect;
5+
}{
6+
flags = "-extension layouts_beta";
7+
expect;
8+
}
49
*)
510

611
(* We should move these back into [basics.ml] once
@@ -18,61 +23,34 @@ type ('a : bits32) t_bits32_id = 'a
1823

1924
type t5_1 = { x : t_bits32 };;
2025
[%%expect{|
21-
Line 1, characters 0-28:
22-
1 | type t5_1 = { x : t_bits32 };;
23-
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
24-
Error: The enabled layouts extension does not allow for mixed records.
25-
You must enable -extension layouts_alpha to use this feature.
26+
type t5_1 = { x : t_bits32; }
2627
|}];;
2728

28-
(* CR layouts v5: this should work *)
2929
type t5_2 = { y : int; x : t_bits32 };;
3030
[%%expect{|
31-
Line 1, characters 0-37:
32-
1 | type t5_2 = { y : int; x : t_bits32 };;
33-
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
34-
Error: The enabled layouts extension does not allow for mixed records.
35-
You must enable -extension layouts_alpha to use this feature.
31+
type t5_2 = { y : int; x : t_bits32; }
3632
|}];;
3733

38-
(* CR layouts: this runs afoul of the mixed block restriction, but should work
39-
once we relax that. *)
4034
type t5_2' = { y : string; x : t_bits32 };;
4135
[%%expect{|
42-
Line 1, characters 0-41:
43-
1 | type t5_2' = { y : string; x : t_bits32 };;
44-
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
45-
Error: The enabled layouts extension does not allow for mixed records.
46-
You must enable -extension layouts_alpha to use this feature.
36+
type t5_2' = { y : string; x : t_bits32; }
4737
|}];;
4838

4939
type t5_4 = A of t_bits32;;
5040
[%%expect{|
51-
Line 1, characters 12-25:
52-
1 | type t5_4 = A of t_bits32;;
53-
^^^^^^^^^^^^^
54-
Error: The enabled layouts extension does not allow for mixed constructors.
55-
You must enable -extension layouts_alpha to use this feature.
41+
type t5_4 = A of t_bits32
5642
|}];;
5743

5844
type t5_5 = A of int * t_bits32;;
5945
[%%expect{|
60-
Line 1, characters 12-31:
61-
1 | type t5_5 = A of int * t_bits32;;
62-
^^^^^^^^^^^^^^^^^^^
63-
Error: The enabled layouts extension does not allow for mixed constructors.
64-
You must enable -extension layouts_alpha to use this feature.
46+
type t5_5 = A of int * t_bits32
6547
|}];;
6648

6749
type ('a : bits32) t5_7 = A of int
6850
type ('a : bits32) t5_8 = A of 'a;;
6951
[%%expect{|
7052
type ('a : bits32) t5_7 = A of int
71-
Line 2, characters 26-33:
72-
2 | type ('a : bits32) t5_8 = A of 'a;;
73-
^^^^^^^
74-
Error: The enabled layouts extension does not allow for mixed constructors.
75-
You must enable -extension layouts_alpha to use this feature.
53+
type ('a : bits32) t5_8 = A of 'a
7654
|}]
7755

7856
(* not allowed: value in flat suffix *)
@@ -93,20 +71,12 @@ type t11_1 = ..
9371
type t11_1 += A of t_bits32;;
9472
[%%expect{|
9573
type t11_1 = ..
96-
Line 3, characters 14-27:
97-
3 | type t11_1 += A of t_bits32;;
98-
^^^^^^^^^^^^^
99-
Error: The enabled layouts extension does not allow for mixed constructors.
100-
You must enable -extension layouts_alpha to use this feature.
74+
type t11_1 += A of t_bits32
10175
|}]
10276

10377
type t11_1 += B of int32#;;
10478
[%%expect{|
105-
Line 1, characters 14-25:
106-
1 | type t11_1 += B of int32#;;
107-
^^^^^^^^^^^
108-
Error: The enabled layouts extension does not allow for mixed constructors.
109-
You must enable -extension layouts_alpha to use this feature.
79+
type t11_1 += B of int32#
11080
|}]
11181

11282
type ('a : bits32) t11_2 = ..
@@ -118,11 +88,7 @@ type 'a t11_2 += B of 'a;;
11888
[%%expect{|
11989
type ('a : bits32) t11_2 = ..
12090
type 'a t11_2 += A of int
121-
Line 5, characters 17-24:
122-
5 | type 'a t11_2 += B of 'a;;
123-
^^^^^^^
124-
Error: The enabled layouts extension does not allow for mixed constructors.
125-
You must enable -extension layouts_alpha to use this feature.
91+
type 'a t11_2 += B of 'a
12692
|}]
12793

12894
(* not allowed: value in flat suffix *)

ocaml/testsuite/tests/typing-layouts-bits32/parsing.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Line 1, characters 9-20:
2020
1 | type t = C of int32#;;
2121
^^^^^^^^^^^
2222
Error: The enabled layouts extension does not allow for mixed constructors.
23-
You must enable -extension layouts_alpha to use this feature.
23+
You must enable -extension layouts_beta to use this feature.
2424
|}];;
2525

2626
type t = C : int32# -> t;;
@@ -29,7 +29,7 @@ Line 1, characters 9-24:
2929
1 | type t = C : int32# -> t;;
3030
^^^^^^^^^^^^^^^
3131
Error: The enabled layouts extension does not allow for mixed constructors.
32-
You must enable -extension layouts_alpha to use this feature.
32+
You must enable -extension layouts_beta to use this feature.
3333
|}];;
3434

3535
(* int32# works as an argument to normal type constructors, not just

0 commit comments

Comments
 (0)