Skip to content

Commit c65dc3e

Browse files
authored
flambda-backend: Advise against new bytecode instructions (#2694)
* Advise against new bytecode instrs * Work around the script that parses instruct.h
1 parent 2b1a2c4 commit c65dc3e

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

runtime/caml/instruct.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,15 @@ enum instructions {
6565
MAKE_FAUX_MIXEDBLOCK,
6666
FIRST_UNIMPLEMENTED_OP};
6767

68+
// Think carefully before adding a new bytecode instruction. In general,
69+
// this makes the flambda-backend compiler less compatible with the
70+
// OCaml ecosystem. Projects may need to be patched to build with
71+
// flambda-backend.
72+
//
73+
// We added the [MAKE_FAUX_MIXEDBLOCK] instruction without making this
74+
// consideration and it has turned out OK, but we might want to reverse
75+
// this decision if we run into difficulty in the future.
76+
6877
#endif /* CAML_INTERNALS */
6978

7079
#endif /* CAML_INSTRUCT_H */

runtime4/caml/instruct.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,15 @@ enum instructions {
6464
MAKE_FAUX_MIXEDBLOCK,
6565
FIRST_UNIMPLEMENTED_OP};
6666

67+
// Think carefully before adding a new bytecode instruction. In general,
68+
// this makes the flambda-backend compiler less compatible with the
69+
// OCaml ecosystem. Projects may need to be patched to build with
70+
// flambda-backend.
71+
//
72+
// We added the [MAKE_FAUX_MIXEDBLOCK] instruction without making this
73+
// consideration and it has turned out OK, but we might want to reverse
74+
// this decision if we run into difficulty in the future.
75+
6776
#endif /* CAML_INTERNALS */
6877

6978
#endif /* CAML_INSTRUCT_H */

0 commit comments

Comments
 (0)