Skip to content

Commit e37e9a0

Browse files
authored
Fixes and re-enables a test (#2454)
* Fixes and re-enables a test * commit the reference file, you dolt
1 parent 510e7b5 commit e37e9a0

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
File "libc/c2.ml", line 1, characters 12-15:
2+
1 | let x = B.f B.x
3+
^^^
4+
Error: Function arguments and returns must be representable.
5+
The layout of A.t is any, because
6+
the .cmi file for A.t is missing.
7+
But the layout of A.t must be representable, because
8+
we must know concretely how to pass a function argument.
9+
No .cmi file found containing A.t.
10+
Hint: Adding "a" to your dependencies might help.

ocaml/testsuite/tests/hidden_includes/test.ml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
(* TEST
2-
reason = "broken due to layout error";
3-
skip;
42
(* This tests the -H flag.
53
64
The basic structure is that libc depends on libb, which depends on liba. We
@@ -37,11 +35,16 @@ flags = "-I liba -I libb -nocwd";
3735
module = "libb/b.ml";
3836
ocamlc.byte;
3937
{
40-
(* Test hiding A completely *)
38+
(* Test hiding A completely. You can't do much with types from it because
39+
their layouts are unknown. *)
4140
flags = "-I libb -nocwd";
4241
module = "libc/c2.ml";
4342
setup-ocamlc.byte-build-env;
43+
ocamlc_byte_exit_status = "2";
4444
ocamlc.byte;
45+
compiler_reference =
46+
"${test_source_directory}/missing_cmi_layout.ocamlc.reference";
47+
check-ocamlc.byte-output;
4548
}
4649
{
4750
(* Test hiding A completely, but using it *)

0 commit comments

Comments
 (0)