-
Notifications
You must be signed in to change notification settings - Fork 89
Finer regionality #1815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
riaqn
wants to merge
12
commits into
oxcaml:main
Choose a base branch
from
riaqn:finer-regionality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Finer regionality #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22138e3
to
c9b8439
Compare
5ddda88
to
f8041db
Compare
43c7653
to
ee03963
Compare
85c62ec
to
1052a1a
Compare
38ba15a
to
f04327e
Compare
Draft
286c83d
to
b7b7f6b
Compare
b7b7f6b
to
6fcc449
Compare
6fcc449
to
1673253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1760
Currently the
Regionality
axis has three levels:global
,regional
andlocal
. This PR generalizes it to natural numbers0, 1, 2, ...
where0
means global,1
means the top level, and so on. For example:z
is0
,y
is2
.x
would be1
, but it will be rejected because we force top-level to be global.Moreover,
Regionality
is indexed as follows:The essential idea is that, by indexing, we can avoid talking about
Regionality = 6
when we are only in 5 layers of nested regions. This is essential for some morphisms to have adjoints.Note that the index starts at
1
instead of0
- this is also essential for some morphisms to have adjoints. Intuitively, some adjunctions lose meanings if there is only "global" and no local to talk about.