Make room for more runtime tags #1857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheNumbat
changed the title
TheNumbat
force-pushed
the
f32-runtime
branch
2 times, most recently
from
fcf8576 to
735c776
Compare
TheNumbat
requested review from
lpw25,
ccasin,
goldfirere,
riaqn,
ncik-roberts,
stedolan,
mshinwell,
poechsel,
gretay-js,
xclerc,
lukemaurer,
Gbury and
lthls
as code owners
Merged
|
Closing this as a different approach is being used now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers
No_scan_tagby 2 to make room for the upcoming boxed float32 tags.The change required updating the tag definitions in the stdlib (Obj.ml), and hence changing our compiler's usage of Obj.*_tag during code generation to new target-specific tags defined in
ocaml/utils/runtimetags.ml.Additionally, bootstrapping the upstream build required additional steps now detailed in HACKING.md.