-
Notifications
You must be signed in to change notification settings - Fork 89
Middle and backend support for unboxed float/int32/int64/nativeint arrays #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only file owned by me.
0e6a9c8
to
3e8fc6b
Compare
This has been updated and now uses custom blocks to represent the arrays. The unboxed |
3e8fc6b
to
2b127b6
Compare
Who is going to review this? @mshinwell and I discussed yesterday that 1) there is no way to test the new codepaths in this PR and 2) we should merge anyway. Tests will come when we add frontend support. But first some review would be good, I think. |
@Gbury is reviewing |
Closing this one since it is superseded by #2185 |
This adds the arrays of the following element layouts to
Lambda
array kinds:float
int32
int64
nativeint
It then threads this through the middle end and backend. It should support all the usual things e.g. static allocation. There are still two things missing [update: now both fixed - see below]:
Abstract_tag
instead ofCustom_tag
just for the moment.There are some places in flambda2 where we could probably now factor out some code.