Skip to content

Fixes and re-enables a test #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fixes and re-enables a test #2454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac77dfe
Fixes and re-enables a test
ccasin Apr 16, 2024
dd251c9
commit the reference file, you dolt
ccasin Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ocaml/testsuite/tests/hidden_includes/missing_cmi_layout.ocamlc.reference
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
File "libc/c2.ml", line 1, characters 12-15:
1 | let x = B.f B.x
^^^
Error: Function arguments and returns must be representable.
The layout of A.t is any, because
the .cmi file for A.t is missing.
But the layout of A.t must be representable, because
we must know concretely how to pass a function argument.
No .cmi file found containing A.t.
Hint: Adding "a" to your dependencies might help.
9 changes: 6 additions & 3 deletions ocaml/testsuite/tests/hidden_includes/test.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
(* TEST
reason = "broken due to layout error";
skip;
(* This tests the -H flag.

The basic structure is that libc depends on libb, which depends on liba. We
Expand Down Expand Up @@ -37,11 +35,16 @@ flags = "-I liba -I libb -nocwd";
module = "libb/b.ml";
ocamlc.byte;
{
(* Test hiding A completely *)
(* Test hiding A completely. You can't do much with types from it because
their layouts are unknown. *)
flags = "-I libb -nocwd";
module = "libc/c2.ml";
setup-ocamlc.byte-build-env;
ocamlc_byte_exit_status = "2";
ocamlc.byte;
compiler_reference =
"${test_source_directory}/missing_cmi_layout.ocamlc.reference";
check-ocamlc.byte-output;
}
{
(* Test hiding A completely, but using it *)
Expand Down