New strategy for safepoint invocation #2463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
force-pushed
the
safepoints-new-sequence
branch
from
f8d07d0 to
c43ee96
Compare
|
Now based on #2464 |
mshinwell
force-pushed
the
safepoints-new-sequence
branch
2 times, most recently
from
00c9251 to
c6bbd9c
Compare
|
This might be in a working state... |
mshinwell
force-pushed
the
safepoints-new-sequence
branch
2 times, most recently
from
8a73038 to
4ea4991
Compare
mshinwell
force-pushed
the
safepoints-new-sequence
branch
from
ee7edeb to
96cea77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a load or store from a protected memory page to trigger entry into the runtime, instead of the existing safepoint mechanism. The code sequence is consequentially rather shorter. When waking up domains, we first wait, hoping that each domain will hit an allocation point (or some other means of entering the runtime, but not a safe point). If that fails, the memory protection is applied to the safepoint trigger page.
This is currently only a sketch and needs testing, not yet ready for review.