Zero alloc: bounded join of witnesses #2489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
xclerc
reviewed
Apr 25, 2024
xclerc
reviewed
Apr 26, 2024
xclerc
approved these changes
Apr 26, 2024
... for the lack of a better name
gretay-js
force-pushed
the
zero_alloc_bounded_witnesses2
branch
from
2ceda6e to
47b532c
Compare
xclerc
approved these changes
May 2, 2024
|
Included in #2524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #2487. Last two commits are new.
Heuristics to limit the number of witnesses tracked by the analysis. This PR does not change precision of the analysis.
The first commit is the same as the first commit of #1472: keep at most
nwitnesses wherenis based on-checkmach-details-cutoff nflag with default 20.The second commit limits the number of elements of a symbolic representation of
Jointhat containsTop. It can result in more or less witnesses depending on how the variables are resolved, but it is a reasonable limit based onnabove and easy to compute.Note that witnesses are not tracked by default for functions that are not annotated with
[@zero_alloc ..]assertions (unless-checkmach-details-cutoffis set to track all witnesses, which is used for displaying allocations in an editor). The motivation of this PR is to ensure that adding an "assert" on a function does not increase compilation overhead unnecessarily.