Skip to content

Load/store float32x4 <-> float32# array #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Load/store float32x4 <-> float32# array #2754

merged 2 commits into from
Jul 4, 2024

Conversation

TheNumbat
Copy link
Contributor

Adds additional 128-bit load/store primitives for float32# arrays.
They operate on float32x4 SIMD vectors, and are otherwise identical to the primitives for other arrays of unboxed numbers.

Tests have been added in tests/simd/arrays.ml.

@TheNumbat TheNumbat requested review from xclerc and removed request for xclerc July 2, 2024 18:08
Copy link
Contributor

@ccasin ccasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple nits. An flambda2 person should confirm we expect array_like_load_128 to work with the Naked_float32s array kind.

@TheNumbat TheNumbat added the simd SIMD support label Jul 3, 2024
@mshinwell
Copy link
Collaborator

Seems fine.

@mshinwell mshinwell merged commit d9485f3 into f32-simd Jul 4, 2024
18 checks passed
@mshinwell mshinwell deleted the f32x4-load branch July 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simd SIMD support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants