Module parameter names should have its own type #3172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riaqn
commented
Oct 22, 2024
| imp_params : Global_module.Parameter.t list; | ||
| imp_arg_for : Global_module.Parameter.t option; | ||
| imp_impl : CU.t; | ||
| imp_raw_sign : Signature_with_global_bindings.t; |
There was a problem hiding this comment.
Discussed offline - we think it's simpler to lift this out to be under import directly.
riaqn
commented
Oct 22, 2024
| if need_local_ident penv global | ||
| match kind with | ||
| | Parameter param -> | ||
| if is_registered_parameter_import penv modname then |
There was a problem hiding this comment.
Discussed offline, this would raise error if we are compiling a parameter.
riaqn
commented
Oct 22, 2024
| | Parameter of Global_module.Parameter.t | ||
| | Normal of { | ||
| pn_global : Global_module.t; | ||
| pn_arg_for : Global_module.Parameter.t option; |
There was a problem hiding this comment.
Discussed offline - this can be removed.
riaqn
changed the title
riaqn
changed the title
|
superseded by #3708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1726
Uses the fact that parameters can't be parameterized, and encode that info in the types. This can help remove some
assert falsein the code.This will be picked up by @lukemaurer when he has time.