Skip to content

Annotate 'a Domain.t as mod portable contended with 'a #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

polytypic
Copy link
Contributor

@polytypic polytypic commented Apr 9, 2025

This crucially makes it possible to Domain.join domain from any other domain without having to unsafely coerce the domain to portable and uncontended.

@polytypic polytypic force-pushed the annotate-domain_t-as-crossing-portended branch from 536ea0b to 46b5d62 Compare April 9, 2025 09:13
@polytypic polytypic changed the title Annotate Domain.t mod portable contended Annotate 'a Domain.t as mod portable contended with 'a Apr 9, 2025
@polytypic
Copy link
Contributor Author

Do we need portable exceptions for this to be sound?

Copy link
Collaborator

@lpw25 lpw25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be sound once we merge portable exceptions. As we are generally accepting some unsoundness until that is merged, we might as well go ahead and merge this now.

@mshinwell mshinwell merged commit dc67a4d into oxcaml:main Jun 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants