-
Notifications
You must be signed in to change notification settings - Fork 89
Initial refactoring of To_cmm #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good but I left comments and I have a few overall remarks:
- outside of one or two shared/helper modules, code in
to_cmm
should never directly build cmm expressions using the datatype constructors; everything should go through smart constructors (as if thecmm
types were private) - we need a better and clearer distinction for what belongs in the
to_cmm_helper
module. what I propose is the following:- have all smart constructors for cmm be in either cmm_helpers or to_cmm_helpers (and thus if you prefer to not have a to_cmm_helper file, move all constructors to the cmm_helpers file) (and again ideally all of these should in my opinion be in the cmm module directly, but it's probably too late for that)
- have simple/arg_list functions that consume flambda2 things and produce cmm be shared be in a
to_cmm_shared
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a lot of small comments, which have to be addressed.
Some notes:
- the formatting of
cmm_helpers
destroyed a lot of formatting in comments which have to be restored, and some parts of the code building some large cmm expressions became (even more) unreadable - we will really need a second PR to harmonize
cmm_helpers.ml
: put the basic smart constructors for cmm expression at the top, and re-use them throughout the file, and try and decide on a common pattern for function signatures (i.e. labelled arguments or not, debuginfo as first or last argument, etc...).
Regarding a second PR to deal with moving functions around in |
… Split out primitive translation code to To_cmm_primitive.
c1e3372
to
6d5d437
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good, waiting for CI to be green.
fe8a98b flambda-backend: Save Mach as Cfg after Selection (#624) 2b205d8 flambda-backend: Clean up algorithms (#611) 524f0b4 flambda-backend: Initial refactoring of To_cmm (#619) 0bf75de flambda-backend: Refactor and correct the "is pure" and "can raise" (port upstream PR#10354 and PR#10387) (#555) d234bfd flambda-backend: Cpp mangling is now a configuration option (#614) 20fc614 flambda-backend: Check that stack frames are not too large (#10085) (#561) 5fc2e95 flambda-backend: Allow CSE of immutable loads across stores (port upstream PR#9562) (#562) 2a650de flambda-backend: Backport commit fc95347 from trunk (#584) 31651b8 flambda-backend: Improved ARM64 code generation (port upstream PR#9937) (#556) f0b6d68 flambda-backend: Simplify processing and remove dead code (error paths) in asmlink (port upstream PR#9943) (#557) 90c6746 flambda-backend: Improve code-generation for inlined comparisons (port upstream PR#10228) (#563) git-subtree-dir: ocaml git-subtree-split: fe8a98b
fe8a98b flambda-backend: Save Mach as Cfg after Selection (oxcaml#624) 2b205d8 flambda-backend: Clean up algorithms (oxcaml#611) 524f0b4 flambda-backend: Initial refactoring of To_cmm (oxcaml#619) 0bf75de flambda-backend: Refactor and correct the "is pure" and "can raise" (port upstream PR#10354 and PR#10387) (oxcaml#555) d234bfd flambda-backend: Cpp mangling is now a configuration option (oxcaml#614) 20fc614 flambda-backend: Check that stack frames are not too large (#10085) (oxcaml#561) 5fc2e95 flambda-backend: Allow CSE of immutable loads across stores (port upstream PR#9562) (oxcaml#562) 2a650de flambda-backend: Backport commit fc95347 from trunk (oxcaml#584) 31651b8 flambda-backend: Improved ARM64 code generation (port upstream PR#9937) (oxcaml#556) f0b6d68 flambda-backend: Simplify processing and remove dead code (error paths) in asmlink (port upstream PR#9943) (oxcaml#557) 90c6746 flambda-backend: Improve code-generation for inlined comparisons (port upstream PR#10228) (oxcaml#563) git-subtree-dir: ocaml git-subtree-split: fe8a98b
454150b flambda-backend: Speed up testsuite (#658) 8362f9e flambda-backend: Speed up builds (#585) a527cab flambda-backend: Update backends for changes from ocaml-jst ce88833 Merge flambda-backend changes b7506bb Revert "Cherry-pick of ocaml/ocaml 1eeb0e7fe595f5f9e1ea1edbdf785ff3b49feeeb (#12)" 183f688 Add config option to enable/disable stack allocation (#22) ee7c849 If both the type and mode of an ident are wrong, complain about the type. (#19) 44bade0 Allow submoding during module inclusion checks (#21) de3bec9 Add subtyping between arrows of related modes (#20) fe8a98b flambda-backend: Save Mach as Cfg after Selection (#624) 2b205d8 flambda-backend: Clean up algorithms (#611) 93d8615 Enable the local keywords even when the local extension is off (#18) 524f0b4 flambda-backend: Initial refactoring of To_cmm (#619) 81dd85e Documentation for local allocations b05519f Fix a GC bug in local stack scanning (#17) 9f879de Fix __FUNCTION__ (#15) 0bf75de flambda-backend: Refactor and correct the "is pure" and "can raise" (port upstream PR#10354 and PR#10387) (#555) d234bfd flambda-backend: Cpp mangling is now a configuration option (#614) 20fc614 flambda-backend: Check that stack frames are not too large (#10085) (#561) 5fc2e95 flambda-backend: Allow CSE of immutable loads across stores (port upstream PR#9562) (#562) 2a650de flambda-backend: Backport commit fc95347 from trunk (#584) a78975e Optimise "include struct ... end" in more cases (ocaml/ocaml#11134) b819c66 Cherry-pick of ocaml/ocaml 1eeb0e7fe595f5f9e1ea1edbdf785ff3b49feeeb (#12) bb363d4 Optimise the allocation of optional arguments (#11) 31651b8 flambda-backend: Improved ARM64 code generation (port upstream PR#9937) (#556) f0b6d68 flambda-backend: Simplify processing and remove dead code (error paths) in asmlink (port upstream PR#9943) (#557) 90c6746 flambda-backend: Improve code-generation for inlined comparisons (port upstream PR#10228) (#563) git-subtree-dir: ocaml git-subtree-split: 454150b
There should be no changes here at all except refactoring. Best read commit by commit. The main things are:
To_cmm_helper
is no longer a dependency ofTo_cmm_env
andTo_cmm_result
. This means we can share more functions between different source files.To_cmm_primitive
.Flambda_unit.t
itself is now inTo_cmm
and the oldTo_cmm
was moved toTo_cmm_expr
.To_cmm_expr
has been significantly shrunk in size, which I think helps to understand the flow of what's going on, although it does mean that some of the helper functions are now further away. Various functions have been simply inlined out; it was kind of hard to follow what was going on before, and this also reduces the risk of variable names diverging (which they had in some places).res
parameters in some places.One of the main aims is to break the code down into smaller pieces so it's easier to check critical invariants, e.g. relating to linear use of the environment.