Skip to content

Fixes for Flambda 2 when Config.stack_allocation is false #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mshinwell
Copy link
Collaborator

Similarly to #812 , when Config.stack_allocation is false, nothing is to be allocated on the local stack:

  1. Don't emit Cmm code for Begin_region and End_region Flambda 2 primitives. These primitives are still present in the Flambda 2 terms because, as of Delete unused local allocation regions in Flambda 2 #809 , region variables are mandatory in allocating primitives and application expressions.
  2. Count Begin_region and End_region as having zero code size.

@mshinwell mshinwell added the flambda2 Prerequisite for, or part of, flambda2 label Sep 7, 2022
@mshinwell
Copy link
Collaborator Author

This is a bit tricky actually, I'm going to put this directly in #809

@mshinwell mshinwell closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flambda2 Prerequisite for, or part of, flambda2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant