Skip to content

Static check for noalloc: rename attribute #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

gretay-js
Copy link
Contributor

Rename [@noalloc] to [@noalloc_strict] in preparation for the [@noalloc_exn] attributed that is introduced in #863 and should probably have a better name.

@gretay-js
Copy link
Contributor Author

gretay-js commented Oct 6, 2022

I misunderstood, it should be [@noalloc strict] with a space, not an underscore. So we end up with [@noalloc strict assume] and/or [@noalloc assume strict] and finally [@noalloc assume] for the non-strict case.
Making the PR into a draft for now to fix it.

@Gbury
Copy link
Contributor

Gbury commented Apr 3, 2023

Can we close this one since #1157 has been opened ?

@gretay-js
Copy link
Contributor Author

superseded by #1157

@gretay-js gretay-js closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants