-
Notifications
You must be signed in to change notification settings - Fork 10
Create a Lang module #333
Comments
Correct me if I'm wrong but as it stands it seems to me that this issue is asking for a module that looks like: type t = [
| `En
| `Fr
| ...
] Am I mistaken? If not, would it make more sense to just use |
Yes, that's it. It is a very simple module. I wanted the type to exist, so that future harder work will be structured around this. Since it is so simple, you could go ahead with some refactoring related to this. Search for values with names like |
The issue will feed into the overall work in #145. |
I consider this issue complete. |
Review of #438: Please update MainLayout and GlobalData modules to use the Lang type. |
Merged ocaml/ocaml.org#540 |
We will need to tag data with the language its written in. We will also need to dispatch logic basic on an indicated language value. Let's be prepared for those scenarios by introducing a
Lang
module which has constants for the current set of languages that ocaml.org supports.We will mostly likely use
react-intl
when implementing internationalization support, so considering imitating how it defines constants: https://github.com/formatjs/formatjs.The text was updated successfully, but these errors were encountered: