Skip to content

Commit 5045a26

Browse files
committed
Refactor use of changedir in tox.ini (open-telemetry#2332)
Fixes #3745
1 parent 0b5e3b4 commit 5045a26

File tree

5 files changed

+80
-22
lines changed

5 files changed

+80
-22
lines changed

instrumentation/opentelemetry-instrumentation-elasticsearch/pyproject.toml

-5
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,6 @@ dependencies = [
3434
instruments = [
3535
"elasticsearch >= 2.0",
3636
]
37-
test = [
38-
"opentelemetry-instrumentation-elasticsearch[instruments]",
39-
"elasticsearch-dsl >= 2.0",
40-
"opentelemetry-test-utils == 0.45b0.dev",
41-
]
4237

4338
[project.entry-points.opentelemetry_instrumentor]
4439
elasticsearch = "opentelemetry.instrumentation.elasticsearch:ElasticsearchInstrumentor"
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
elasticsearch==2.4.1
5+
elasticsearch-dsl==2.2.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
packaging==23.2
9+
pluggy==1.4.0
10+
py==1.11.0
11+
py-cpuinfo==9.0.0
12+
pytest==7.1.3
13+
pytest-benchmark==4.0.0
14+
python-dateutil==2.8.2
15+
six==1.16.0
16+
tomli==2.0.1
17+
typing_extensions==4.10.0
18+
urllib3==1.26.18
19+
wrapt==1.16.0
20+
zipp==3.17.0
21+
-e opentelemetry-instrumentation
22+
-e instrumentation/opentelemetry-instrumentation-elasticsearch
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
elasticsearch==5.5.3
5+
elasticsearch-dsl==5.4.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
packaging==23.2
9+
pluggy==1.4.0
10+
py==1.11.0
11+
py-cpuinfo==9.0.0
12+
pytest==7.1.3
13+
pytest-benchmark==4.0.0
14+
python-dateutil==2.8.2
15+
six==1.16.0
16+
tomli==2.0.1
17+
typing_extensions==4.10.0
18+
urllib3==2.2.1
19+
wrapt==1.16.0
20+
zipp==3.17.0
21+
-e opentelemetry-instrumentation
22+
-e instrumentation/opentelemetry-instrumentation-elasticsearch
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
asgiref==3.7.2
2+
attrs==23.2.0
3+
Deprecated==1.2.14
4+
elasticsearch==6.8.2
5+
elasticsearch-dsl==6.4.0
6+
importlib-metadata==6.11.0
7+
iniconfig==2.0.0
8+
packaging==23.2
9+
pluggy==1.4.0
10+
py==1.11.0
11+
py-cpuinfo==9.0.0
12+
pytest==7.1.3
13+
pytest-benchmark==4.0.0
14+
python-dateutil==2.8.2
15+
six==1.16.0
16+
tomli==2.0.1
17+
typing_extensions==4.10.0
18+
urllib3==2.2.1
19+
wrapt==1.16.0
20+
zipp==3.17.0
21+
-e opentelemetry-instrumentation
22+
-e instrumentation/opentelemetry-instrumentation-elasticsearch

tox.ini

+14-17
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,16 @@ envlist =
7575
; pypy3-test-instrumentation-boto
7676

7777
; opentelemetry-instrumentation-elasticsearch
78-
py3{8,9,10,11}-test-instrumentation-elasticsearch-{2,6}
79-
pypy3-test-instrumentation-elasticsearch-{2,6}
80-
py3{8,9}-test-instrumentation-elasticsearch-5
81-
pypy3-test-instrumentation-elasticsearch-5
78+
; FIXME: Elasticsearch >=7 causes CI workflow tests to hang, see open-telemetry/opentelemetry-python-contrib#620
79+
; The numbers at the end of the environment names
80+
; below mean these dependencies are being used:
81+
; 0: elasticsearch-dsl>=2.0,<3.0 elasticsearch>=2.0,<3.0
82+
; 1: elasticsearch-dsl>=5.0,<6.0 elasticsearch>=5.0,<6.0
83+
; 2: elasticsearch-dsl>=6.0,<7.0 elasticsearch>=6.0,<7.0
84+
py3{8,9,10,11}-test-instrumentation-elasticsearch-{0,2}
85+
pypy3-test-instrumentation-elasticsearch-{0,2}
86+
py3{8,9}-test-instrumentation-elasticsearch-1
87+
pypy3-test-instrumentation-elasticsearch-1
8288

8389
; opentelemetry-instrumentation-falcon
8490
; py310 does not work with falcon 1
@@ -289,17 +295,6 @@ deps =
289295
test: pytest-benchmark
290296
coverage: pytest
291297
coverage: pytest-cov
292-
elasticsearch-2: elasticsearch-dsl>=2.0,<3.0
293-
elasticsearch-2: elasticsearch>=2.0,<3.0
294-
elasticsearch-5: elasticsearch-dsl>=5.0,<6.0
295-
elasticsearch-5: elasticsearch>=5.0,<6.0
296-
elasticsearch-6: elasticsearch-dsl>=6.0,<7.0
297-
elasticsearch-6: elasticsearch>=6.0,<7.0
298-
; FIXME: Elasticsearch >=7 causes CI workflow tests to hang, see open-telemetry/opentelemetry-python-contrib#620
299-
; elasticsearch-7: elasticsearch-dsl>=7.0,<8.0
300-
; elasticsearch-7: elasticsearch>=7.0,<8.0
301-
; elasticsearch-8: elasticsearch-dsl>=8.0,<9.0
302-
; elasticsearch-8: elasticsearch>=8.0,<9.0
303298
grpc: pytest-asyncio
304299
sqlalchemy-11: sqlalchemy>=1.1,<1.2
305300
sqlalchemy-14: aiosqlite
@@ -441,7 +436,9 @@ commands_pre =
441436

442437
sqlalchemy-{11,14}: pip install {toxinidir}/instrumentation/opentelemetry-instrumentation-sqlalchemy[test]
443438

444-
elasticsearch-{2,5,6}: pip install {toxinidir}/opentelemetry-instrumentation[test] {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch[test]
439+
elasticsearch-0: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-0.txt
440+
elasticsearch-1: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-1.txt
441+
elasticsearch-2: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-2.txt
445442

446443
asyncio: pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncio/test-requirements.txt
447444

@@ -604,7 +601,7 @@ commands_pre =
604601
# for your OS to install the required dependencies
605602
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-mysqlclient[test]
606603
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-pymongo[test]
607-
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch[test]
604+
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-elasticsearch/test-requirements-2.txt
608605
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-asyncpg[test]
609606
pip install -r {toxinidir}/instrumentation/opentelemetry-instrumentation-tornado/test-requirements.txt
610607
python -m pip install -e {toxinidir}/instrumentation/opentelemetry-instrumentation-tortoiseorm[test]

0 commit comments

Comments
 (0)