Skip to content

Test broken on NodeJS v18 #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wolfy1339 opened this issue Jul 14, 2022 · 2 comments
Closed

Test broken on NodeJS v18 #492

wolfy1339 opened this issue Jul 14, 2022 · 2 comments
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@wolfy1339
Copy link
Member

The cause would be #442

FAIL test/request.test.ts (8.87 s)
  ● request() › options.request.signal is passed as option to fetch
    expect(received).toMatch(expected)
    Expected pattern: /\bsignal\b/i
    Received string:  "AbortSignal: Expected funk to be an instance of AbortSignal."
      587 |
      588 |       .catch((error) => {
    > 589 |         expect(error.message).toMatch(/\bsignal\b/i);
          |                               ^
      590 |         expect(error.message).toMatch(/\bAbortSignal\b/i);
      591 |       });
      592 |   });
      at test/request.test.ts:589:31
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jul 14, 2022
@wolfy1339
Copy link
Member Author

node-fetch/node-fetch#1554
That offers some insight with the error message

@wolfy1339
Copy link
Member Author

Fixed by #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

No branches or pull requests

1 participant