Skip to content

Commit 024f967

Browse files
committed
rust: workqueue: remove unneeded `#[allow(clippy::new_ret_no_self)]
Perform the same clean commit b2516f7 ("rust: kernel: remove `#[allow(clippy::new_ret_no_self)]`") did for a case that appeared in workqueue in parallel in commit 7324b88 ("rust: workqueue: add helper for defining work_struct fields"): Clippy triggered a false positive on its `new_ret_no_self` lint when using the `pin_init!` macro. Since Rust 1.67.0, that does not happen anymore, since Clippy learnt to not warn about `-> impl Trait<Self>` [1][2]. The kernel nowadays uses Rust 1.72.1, thus remove the `#[allow]`. Link: rust-lang/rust-clippy#7344 [1] Link: rust-lang/rust-clippy#9733 [2] Reviewed-by: Alice Ryhl <[email protected]> Reviewed-by: Trevor Gross <[email protected]> Tested-by: Gary Guo <[email protected]> Reviewed-by: Gary Guo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Miguel Ojeda <[email protected]>
1 parent d407317 commit 024f967

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

rust/kernel/workqueue.rs

-1
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,6 @@ unsafe impl<T: ?Sized, const ID: u64> Sync for Work<T, ID> {}
366366
impl<T: ?Sized, const ID: u64> Work<T, ID> {
367367
/// Creates a new instance of [`Work`].
368368
#[inline]
369-
#[allow(clippy::new_ret_no_self)]
370369
pub fn new(name: &'static CStr, key: &'static LockClassKey) -> impl PinInit<Self>
371370
where
372371
T: WorkItem<ID>,

0 commit comments

Comments
 (0)