Skip to content

Commit a6a7cba

Browse files
1715173329mmind
authored andcommitted
arm64: dts: rockchip: change eth phy mode to rgmii-id for orangepi r1 plus lts
In general the delay should be added by the PHY instead of the MAC, and this improves network stability on some boards which seem to need different delay. Fixes: 387b3bb ("arm64: dts: rockchip: Add Xunlong OrangePi R1 Plus LTS") Cc: [email protected] # 6.6+ Signed-off-by: Tianling Shen <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 5c8f9a0 commit a6a7cba

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus-lts.dts

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717

1818
&gmac2io {
1919
phy-handle = <&yt8531c>;
20-
tx_delay = <0x19>;
21-
rx_delay = <0x05>;
20+
phy-mode = "rgmii-id";
2221
status = "okay";
2322

2423
mdio {

arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus.dts

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
&gmac2io {
1717
phy-handle = <&rtl8211e>;
18+
phy-mode = "rgmii";
1819
tx_delay = <0x24>;
1920
rx_delay = <0x18>;
2021
status = "okay";

arch/arm64/boot/dts/rockchip/rk3328-orangepi-r1-plus.dtsi

-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@
109109
assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>;
110110
assigned-clock-parents = <&gmac_clk>, <&gmac_clk>;
111111
clock_in_out = "input";
112-
phy-mode = "rgmii";
113112
phy-supply = <&vcc_io>;
114113
pinctrl-0 = <&rgmiim1_pins>;
115114
pinctrl-names = "default";

0 commit comments

Comments
 (0)