Skip to content

Commit 1ac6bf9

Browse files
committed
Drop unused code
1 parent 27e9ed4 commit 1ac6bf9

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

tests/PhpSpreadsheetTests/Reader/Security/XmlScannerTest.php

+4-6
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class XmlScannerTest extends TestCase
1717
* @param mixed $filename
1818
* @param mixed $expectedResult
1919
*/
20-
public function testValidXML($filename, $expectedResult, bool $libxmlDisableEntityLoader): void
20+
public function testValidXML($filename, $expectedResult): void
2121
{
2222
$reader = XmlScanner::getInstance(new \PhpOffice\PhpSpreadsheet\Reader\Xml());
2323
$result = $reader->scanFile($filename);
@@ -32,8 +32,7 @@ public static function providerValidXML(): array
3232
foreach ($glob as $file) {
3333
$filename = realpath($file);
3434
$expectedResult = file_get_contents($file);
35-
$tests[basename($file) . '_libxml_entity_loader_disabled'] = [$filename, $expectedResult, true];
36-
$tests[basename($file) . '_libxml_entity_loader_enabled'] = [$filename, $expectedResult, false];
35+
$tests[basename($file)] = [$filename, $expectedResult];
3736
}
3837

3938
return $tests;
@@ -44,7 +43,7 @@ public static function providerValidXML(): array
4443
*
4544
* @param mixed $filename
4645
*/
47-
public function testInvalidXML($filename, bool $libxmlDisableEntityLoader): void
46+
public function testInvalidXML($filename): void
4847
{
4948
$this->expectException(\PhpOffice\PhpSpreadsheet\Reader\Exception::class);
5049

@@ -61,8 +60,7 @@ public static function providerInvalidXML(): array
6160
self::assertNotFalse($glob);
6261
foreach ($glob as $file) {
6362
$filename = realpath($file);
64-
$tests[basename($file) . '_libxml_entity_loader_disabled'] = [$filename, true];
65-
$tests[basename($file) . '_libxml_entity_loader_enabled'] = [$filename, false];
63+
$tests[basename($file)] = [$filename];
6664
}
6765

6866
return $tests;

0 commit comments

Comments
 (0)