cleanup

Author: olucurious

.github/workflows/python-app.yml

@@ -47,7 +47,6 @@ jobs:
         python -m black -t py310 --check .
     - name: Test with pytest
       run: |
-        export FCM_TEST_API_KEY=AAA
         export FCM_TEST_PROJECT_ID=test
         pip install . ".[test]"
         python -m pytest .

tests/conftest.py

@@ -10,12 +10,15 @@
 
 @pytest.fixture(scope="module")
 def push_service():
-    service_account = os.getenv("GOOGLE_APPLICATION_CREDENTIALS", "TEST")
+    service_account_file = os.getenv("GOOGLE_APPLICATION_CREDENTIALS", None)
+    project_id = os.getenv("FCM_TEST_PROJECT_ID", None)
     assert (
-        service_account
+        service_account_file
     ), "Please set the service_account for testing according to CONTRIBUTING.rst"
 
-    return FCMNotification(service_account_file=service_account, project_id="TEST")
+    return FCMNotification(
+        service_account_file=service_account_file, project_id=project_id
+    )
 
 
 @pytest.fixture

tests/test_fcm.py

@@ -19,24 +19,3 @@ def test_notify(push_service, generate_response):
     )
 
     assert isinstance(response, dict)
-
-
-def test_async_notify(push_service, mock_aiohttp_session):
-    params = {
-        "fcm_token": "test",
-        "notification_title": "test",
-        "notification_body": "test",
-        "notification_image": "test",
-        "data_payload": {"test": "test"},
-        "topic_name": "test",
-        "topic_condition": "test",
-        "android_config": {},
-        "apns_config": {},
-        "webpush_config": {},
-        "fcm_options": {},
-        "dry_run": False,
-    }
-
-    params_list = [params for _ in range(100)]
-
-    push_service.send_async_request(params_list, timeout=5)