Skip to content

Commit 09b3a7c

Browse files
committed
Change error to INVALID_OPERATION
1 parent f685bb3 commit 09b3a7c

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

source/adapters/cuda/command_buffer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,7 @@ urCommandBufferReleaseExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
401401

402402
UR_APIEXPORT ur_result_t UR_APICALL
403403
urCommandBufferFinalizeExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
404-
UR_ASSERT(!hCommandBuffer->IsFinalized,
405-
UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP);
404+
UR_ASSERT(!hCommandBuffer->IsFinalized, UR_RESULT_ERROR_INVALID_OPERATION);
406405
try {
407406
const unsigned long long flags = 0;
408407
#if CUDA_VERSION >= 12000

source/adapters/hip/command_buffer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,8 +306,7 @@ urCommandBufferReleaseExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
306306

307307
UR_APIEXPORT ur_result_t UR_APICALL
308308
urCommandBufferFinalizeExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
309-
UR_ASSERT(!hCommandBuffer->IsFinalized,
310-
UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP);
309+
UR_ASSERT(!hCommandBuffer->IsFinalized, UR_RESULT_ERROR_INVALID_OPERATION);
311310
try {
312311
const unsigned long long flags = 0;
313312
UR_CHECK_ERROR(hipGraphInstantiateWithFlags(

source/adapters/level_zero/command_buffer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -595,8 +595,7 @@ urCommandBufferReleaseExp(ur_exp_command_buffer_handle_t CommandBuffer) {
595595
ur_result_t
596596
urCommandBufferFinalizeExp(ur_exp_command_buffer_handle_t CommandBuffer) {
597597
UR_ASSERT(CommandBuffer, UR_RESULT_ERROR_INVALID_NULL_POINTER);
598-
UR_ASSERT(!CommandBuffer->IsFinalized,
599-
UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP);
598+
UR_ASSERT(!CommandBuffer->IsFinalized, UR_RESULT_ERROR_INVALID_OPERATION);
600599
// It is not allowed to append to command list from multiple threads.
601600
std::scoped_lock<ur_shared_mutex> Guard(CommandBuffer->Mutex);
602601

source/adapters/opencl/command_buffer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,7 @@ urCommandBufferReleaseExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
124124

125125
UR_APIEXPORT ur_result_t UR_APICALL
126126
urCommandBufferFinalizeExp(ur_exp_command_buffer_handle_t hCommandBuffer) {
127-
UR_ASSERT(!hCommandBuffer->IsFinalized,
128-
UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP);
127+
UR_ASSERT(!hCommandBuffer->IsFinalized, UR_RESULT_ERROR_INVALID_OPERATION);
129128
cl_context CLContext = cl_adapter::cast<cl_context>(hCommandBuffer->hContext);
130129
cl_ext::clFinalizeCommandBufferKHR_fn clFinalizeCommandBufferKHR = nullptr;
131130
UR_RETURN_ON_FAILURE(

test/conformance/exp_command_buffer/commands.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,6 @@ TEST_P(urCommandBufferAppendKernelLaunchExpTest, FinalizeTwice) {
213213

214214
ASSERT_SUCCESS(urCommandBufferFinalizeExp(cmd_buf_handle));
215215
EXPECT_EQ_RESULT(urCommandBufferFinalizeExp(cmd_buf_handle),
216-
UR_RESULT_ERROR_INVALID_COMMAND_BUFFER_EXP);
216+
UR_RESULT_ERROR_INVALID_OPERATION);
217217

218218
}

0 commit comments

Comments
 (0)