Merge pull request #1747 from AllanZyne/review/yang/misalign_access

[DeviceSanitizer] Support detecting misaligned access error

Author: kbenzie

source/loader/layers/sanitizer/asan_interceptor.cpp

@@ -358,15 +358,17 @@ ur_result_t SanitizerInterceptor::postLaunchKernel(ur_kernel_handle_t Kernel,
             if (!AH.Flag) {
                 continue;
             }
-            if (AH.ErrorType == DeviceSanitizerErrorType::USE_AFTER_FREE) {
+            switch (AH.ErrorType) {
+            case DeviceSanitizerErrorType::USE_AFTER_FREE:
                 ReportUseAfterFree(AH, Kernel, GetContext(Queue));
-            } else if (AH.ErrorType ==
-                           DeviceSanitizerErrorType::OUT_OF_BOUNDS ||
-                       AH.ErrorType == DeviceSanitizerErrorType::MISALIGNED ||
-                       AH.ErrorType == DeviceSanitizerErrorType::NULL_POINTER) {
-                ReportOutOfBoundsError(AH, Kernel);
-            } else {
-                ReportGenericError(AH);
+                break;
+            case DeviceSanitizerErrorType::OUT_OF_BOUNDS:
+            case DeviceSanitizerErrorType::MISALIGNED:
+            case DeviceSanitizerErrorType::NULL_POINTER:
+                ReportGenericError(AH, Kernel);
+                break;
+            default:
+                ReportFatalError(AH);
             }
             if (!AH.IsRecover) {
                 exit(1);

source/loader/layers/sanitizer/asan_report.cpp

@@ -76,13 +76,13 @@ void ReportDoubleFree(uptr Addr, const StackTrace &Stack,
     AI->AllocStack.print();
 }
 
-void ReportGenericError(const DeviceSanitizerReport &Report) {
+void ReportFatalError(const DeviceSanitizerReport &Report) {
     context.logger.always("\n====ERROR: DeviceSanitizer: {}",
                           ToString(Report.ErrorType));
 }
 
-void ReportOutOfBoundsError(const DeviceSanitizerReport &Report,
-                            ur_kernel_handle_t Kernel) {
+void ReportGenericError(const DeviceSanitizerReport &Report,
+                        ur_kernel_handle_t Kernel) {
     const char *File = Report.File[0] ? Report.File : "<unknown file>";
     const char *Func = Report.Func[0] ? Report.Func : "<unknown func>";
     auto KernelName = GetKernelName(Kernel);

source/loader/layers/sanitizer/asan_report.hpp

@@ -31,10 +31,11 @@ void ReportBadContext(uptr Addr, const StackTrace &stack,
 void ReportDoubleFree(uptr Addr, const StackTrace &Stack,
                       const std::shared_ptr<AllocInfo> &AllocInfo);
 
-void ReportGenericError(const DeviceSanitizerReport &Report);
+// This type of error is usually unexpected mistake and doesn't have enough debug information
+void ReportFatalError(const DeviceSanitizerReport &Report);
 
-void ReportOutOfBoundsError(const DeviceSanitizerReport &Report,
-                            ur_kernel_handle_t Kernel);
+void ReportGenericError(const DeviceSanitizerReport &Report,
+                        ur_kernel_handle_t Kernel);
 
 void ReportUseAfterFree(const DeviceSanitizerReport &Report,
                         ur_kernel_handle_t Kernel, ur_context_handle_t Context);