Skip to content

Commit 3fc52b2

Browse files
authored
Merge pull request #1889 from pbalcer/fix-sampler-fixture
fix sampler test fixture
2 parents e161516 + 1e4a0e9 commit 3fc52b2

File tree

2 files changed

+19
-25
lines changed

2 files changed

+19
-25
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,19 +0,0 @@
1-
urSamplerCreateWithNativeHandleTest.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
2-
urSamplerGetInfoTestWithParam.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}__UR_SAMPLER_INFO_REFERENCE_COUNT
3-
urSamplerGetInfoTestWithParam.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}__UR_SAMPLER_INFO_CONTEXT
4-
urSamplerGetInfoTestWithParam.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}__UR_SAMPLER_INFO_NORMALIZED_COORDS
5-
urSamplerGetInfoTestWithParam.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}__UR_SAMPLER_INFO_ADDRESSING_MODE
6-
urSamplerGetInfoTestWithParam.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}__UR_SAMPLER_INFO_FILTER_MODE
7-
urSamplerGetInfoTest.InvalidNullHandleSampler/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
8-
urSamplerGetInfoTest.InvalidEnumerationInfo/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
9-
urSamplerGetInfoTest.InvalidNullPointerPropSizeRet/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
10-
urSamplerGetInfoTest.InvalidNullPointerPropValue/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
11-
urSamplerGetInfoTest.InvalidSizePropSizeZero/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
12-
urSamplerGetInfoTest.InvalidSizePropSizeSmall/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
13-
urSamplerGetNativeHandleTest.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
14-
urSamplerGetNativeHandleTest.InvalidNullHandleSampler/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
15-
urSamplerGetNativeHandleTest.InvalidNullPointerNativeHandle/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
16-
urSamplerReleaseTest.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
17-
urSamplerReleaseTest.InvalidNullHandleSampler/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
18-
urSamplerRetainTest.Success/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}
19-
urSamplerRetainTest.InvalidNullHandleSampler/SYCL_NATIVE_CPU___SYCL_Native_CPU__{{.*}}

test/conformance/testing/include/uur/fixtures.h

+19-6
Original file line numberDiff line numberDiff line change
@@ -159,15 +159,21 @@ struct urSamplerTest : urContextTest {
159159
UR_SAMPLER_ADDRESSING_MODE_CLAMP, /* addressing mode */
160160
UR_SAMPLER_FILTER_MODE_LINEAR, /* filterMode */
161161
};
162-
ASSERT_SUCCESS(urSamplerCreate(context, &sampler_desc, &sampler));
162+
auto ret = urSamplerCreate(context, &sampler_desc, &sampler);
163+
if (ret == UR_RESULT_ERROR_UNSUPPORTED_FEATURE ||
164+
ret == UR_RESULT_ERROR_UNINITIALIZED) {
165+
GTEST_SKIP() << "urSamplerCreate not supported";
166+
}
163167
}
164168

165169
void TearDown() override {
166-
EXPECT_SUCCESS(urSamplerRelease(sampler));
170+
if (sampler) {
171+
EXPECT_SUCCESS(urSamplerRelease(sampler));
172+
}
167173
UUR_RETURN_ON_FATAL_FAILURE(urContextTest::TearDown());
168174
}
169175

170-
ur_sampler_handle_t sampler;
176+
ur_sampler_handle_t sampler = nullptr;
171177
ur_sampler_desc_t sampler_desc;
172178
};
173179

@@ -263,15 +269,22 @@ template <class T> struct urSamplerTestWithParam : urContextTestWithParam<T> {
263269
UR_SAMPLER_ADDRESSING_MODE_CLAMP, /* addressing mode */
264270
UR_SAMPLER_FILTER_MODE_LINEAR, /* filterMode */
265271
};
266-
ASSERT_SUCCESS(urSamplerCreate(this->context, &sampler_desc, &sampler));
272+
auto ret = urSamplerCreate(this->context, &sampler_desc, &sampler);
273+
if (ret == UR_RESULT_ERROR_UNSUPPORTED_FEATURE ||
274+
ret == UR_RESULT_ERROR_UNINITIALIZED) {
275+
GTEST_SKIP() << "urSamplerCreate not supported";
276+
}
267277
}
268278

269279
void TearDown() override {
270-
EXPECT_SUCCESS(urSamplerRelease(sampler));
280+
if (sampler) {
281+
EXPECT_SUCCESS(urSamplerRelease(sampler));
282+
}
283+
271284
UUR_RETURN_ON_FATAL_FAILURE(urContextTestWithParam<T>::TearDown());
272285
}
273286

274-
ur_sampler_handle_t sampler;
287+
ur_sampler_handle_t sampler = nullptr;
275288
ur_sampler_desc_t sampler_desc;
276289
};
277290

0 commit comments

Comments
 (0)