Skip to content

Commit 880b0eb

Browse files
authored
Update tracing props (spring-attic#5925)
* Update Prometheus Rsocket property name This property rename was missed during the initial update to Prometheus Rsocket 2.0.0-M1 (b61c3c9). * Update tracing props in Docker Compose files This updates the Wavefront and Zipkin docker compose templates with the properly named tracing related properties to enable traces exported for each.
1 parent 9264222 commit 880b0eb

File tree

6 files changed

+18
-12
lines changed

6 files changed

+18
-12
lines changed

spring-cloud-dataflow-server-core/src/main/resources/META-INF/dataflow-server-defaults.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ management:
1414
autotime:
1515
enabled: true # true is default to Boot 2.3.2 at least.
1616
percentiles-histogram: true
17-
export:
18-
prometheus:
19-
rsocket:
20-
enabled: false
2117
influx:
2218
metrics:
2319
export:
@@ -26,6 +22,8 @@ management:
2622
metrics:
2723
export:
2824
enabled: false
25+
rsocket:
26+
enabled: false
2927
wavefront:
3028
metrics:
3129
export:

spring-cloud-skipper/spring-cloud-skipper-server-core/src/main/resources/application.yml

+2-4
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ management:
2525
autotime:
2626
enabled: true # true is default to Boot 2.3.2 at least.
2727
percentiles-histogram: true
28-
export:
29-
prometheus:
30-
rsocket:
31-
enabled: false
3228
influx:
3329
metrics:
3430
export:
@@ -37,6 +33,8 @@ management:
3733
metrics:
3834
export:
3935
enabled: false
36+
rsocket:
37+
enabled: false
4038
wavefront:
4139
metrics:
4240
export:

src/docker-compose/docker-compose-wavefront.yml

+3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ services:
1414
- MANAGEMENT_WAVEFRONT_METRICS_EXPORT_APITOKEN=${WAVEFRONT_KEY:?WAVEFRONT_KEY is not set!}
1515
- MANAGEMENT_WAVEFRONT_METRICS_EXPORT_URI=${WAVEFRONT_URI:-https://vmware.wavefront.com}
1616
- MANAGEMENT_WAVEFRONT_METRICS_EXPORT_SOURCE=${WAVEFRONT_SOURCE:-scdf-docker-compose}
17+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_ENABLED=true
18+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_SAMPLING_PROBABILITY=1.0
19+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_WAVEFRONT_TRACING_EXPORT_ENABLED=true
1720
- SPRING_APPLICATION_JSON={"spring.jpa.properties.hibernate.generate_statistics":true}
1821

1922
skipper-server:

src/docker-compose/docker-compose-zipkin.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,7 @@ services:
1515

1616
dataflow-server:
1717
environment:
18-
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_SPRING_ZIPKIN_ENABLED=true
19-
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_SPRING_ZIPKIN_BASEURL=http://zipkin-server:9411
18+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_ENABLED=true
19+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_SAMPLING_PROBABILITY=1.0
20+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_ZIPKIN_TRACING_EXPORT_ENABLED=true
21+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_ZIPKIN_TRACING_ENDPOINT=http://zipkin-server:9411/api/v2/spans

src/templates/docker-compose/docker-compose-wavefront.yml

+3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ services:
1414
- MANAGEMENT_WAVEFRONT_METRICS_EXPORT_APITOKEN=${WAVEFRONT_KEY:?WAVEFRONT_KEY is not set!}
1515
- MANAGEMENT_WAVEFRONT_METRICS_EXPORT_URI=${WAVEFRONT_URI:-https://vmware.wavefront.com}
1616
- MANAGEMENT_WAVEFRONT_METRICS_EXPORT_SOURCE=${WAVEFRONT_SOURCE:-scdf-docker-compose}
17+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_ENABLED=true
18+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_SAMPLING_PROBABILITY=1.0
19+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_WAVEFRONT_TRACING_EXPORT_ENABLED=true
1720
- SPRING_APPLICATION_JSON={"spring.jpa.properties.hibernate.generate_statistics":true}
1821

1922
skipper-server:

src/templates/docker-compose/docker-compose-zipkin.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,7 @@ services:
1515

1616
dataflow-server:
1717
environment:
18-
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_SPRING_ZIPKIN_ENABLED=true
19-
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_SPRING_ZIPKIN_BASEURL=http://zipkin-server:9411
18+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_ENABLED=true
19+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_TRACING_SAMPLING_PROBABILITY=1.0
20+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_ZIPKIN_TRACING_EXPORT_ENABLED=true
21+
- SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_MANAGEMENT_ZIPKIN_TRACING_ENDPOINT=http://zipkin-server:9411/api/v2/spans

0 commit comments

Comments
 (0)