Skip to content

Commit d38b9d9

Browse files
committed
v1.16.5
1 parent b55f80d commit d38b9d9

File tree

5 files changed

+12
-6
lines changed

5 files changed

+12
-6
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## 1.16.5
2+
3+
Ginkgo 2.0 now has a Release Candidate. 1.16.5 advertises the existence of the RC.
4+
1.16.5 deprecates GinkgoParallelNode in favor of GinkgoParallelProcess
5+
6+
You can silence the RC advertisement by setting an `ACK_GINKG_RC=true` environment variable or creating a file in your home directory called `.ack-ginkgo-rc`
7+
18
## 1.16.4
29

310
### Fixes

config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import (
2020
"fmt"
2121
)
2222

23-
const VERSION = "1.16.4"
23+
const VERSION = "1.16.5"
2424

2525
type GinkgoConfigType struct {
2626
RandomSeed int64

ginkgo/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ func emitRCAdvertisement() {
327327
out += formatter.F("{{light-yellow}}=========================={{/}}\n")
328328
out += formatter.F("{{bold}}{{green}}Ginkgo 2.0{{/}} is under active development and will introduce several new features, improvements, and a small handful of breaking changes.\n")
329329
out += formatter.F("A release candidate for 2.0 is now available and 2.0 should GA in Fall 2021. {{bold}}Please give the RC a try and send us feedback!{{/}}\n")
330-
out += formatter.F(" - To learn more, view the migration guide at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md{{/}}\n")
330+
out += formatter.F(" - To learn more, view the migration guide at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md{{/}}\n")
331331
out += formatter.F(" - For instructions on using the Release Candidate visit {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#using-the-beta{{/}}\n")
332332
out += formatter.F(" - To comment, chime in at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/issues/711{{/}}\n\n")
333333
out += formatter.F("To {{bold}}{{coral}}silence this notice{{/}}, set the environment variable: {{bold}}ACK_GINKGO_RC=true{{/}}\n")

internal/writer/writer_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ var _ = Describe("Writer", func() {
2020
It("should stream directly to the outbuffer by default", func() {
2121
writer.Write([]byte("foo"))
2222
Ω(out).Should(gbytes.Say("foo"))
23-
Fail("boom")
2423
})
2524

2625
It("should not emit the header when asked to DumpOutWitHeader", func() {

types/deprecation_support.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,18 +107,18 @@ func (d *DeprecationTracker) DidTrackDeprecations() bool {
107107
}
108108

109109
func (d *DeprecationTracker) DeprecationsReport() string {
110-
out := formatter.F("{{light-yellow}}You're using deprecated Ginkgo functionality:{{/}}\n")
110+
out := formatter.F("\n{{light-yellow}}You're using deprecated Ginkgo functionality:{{/}}\n")
111111
out += formatter.F("{{light-yellow}}============================================={{/}}\n")
112112
out += formatter.F("{{bold}}{{green}}Ginkgo 2.0{{/}} is under active development and will introduce several new features, improvements, and a small handful of breaking changes.\n")
113113
out += formatter.F("A release candidate for 2.0 is now available and 2.0 should GA in Fall 2021. {{bold}}Please give the RC a try and send us feedback!{{/}}\n")
114-
out += formatter.F(" - To learn more, view the migration guide at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md{{/}}\n")
114+
out += formatter.F(" - To learn more, view the migration guide at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md{{/}}\n")
115115
out += formatter.F(" - For instructions on using the Release Candidate visit {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#using-the-beta{{/}}\n")
116116
out += formatter.F(" - To comment, chime in at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/issues/711{{/}}\n\n")
117117

118118
for deprecation, locations := range d.deprecations {
119119
out += formatter.Fi(1, "{{yellow}}"+deprecation.Message+"{{/}}\n")
120120
if deprecation.DocLink != "" {
121-
out += formatter.Fi(1, "{{bold}}Learn more at:{{/}} {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#%s{{/}}\n", deprecation.DocLink)
121+
out += formatter.Fi(1, "{{bold}}Learn more at:{{/}} {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#%s{{/}}\n", deprecation.DocLink)
122122
}
123123
for _, location := range locations {
124124
out += formatter.Fi(2, "{{gray}}%s{{/}}\n", location)

0 commit comments

Comments
 (0)