Skip to content

Commit d12bbc7

Browse files
fix: Update usage of StatsigServerOptions (#169)
Signed-off-by: Jens Henneberg <[email protected]>
1 parent f5c80e9 commit d12bbc7

File tree

4 files changed

+15
-17
lines changed

4 files changed

+15
-17
lines changed

Diff for: src/OpenFeature.Contrib.Providers.Statsig/EvaluationContextExtensions.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ namespace OpenFeature.Contrib.Providers.Statsig
55
{
66
internal static class EvaluationContextExtensions
77
{
8-
//These keys match the keys of the statsiguser object as descibed here
8+
//These keys match the keys of the statsiguser object as described here
99
//https://docs.statsig.com/client/concepts/user
1010
internal const string CONTEXT_APP_VERSION = "appVersion";
1111
internal const string CONTEXT_COUNTRY = "country";

Diff for: src/OpenFeature.Contrib.Providers.Statsig/README.md

+9-9
Original file line numberDiff line numberDiff line change
@@ -10,32 +10,32 @@ The first things we will do is install the **Open Feature SDK** and the **Statsi
1010

1111
### .NET Cli
1212
```shell
13-
dotnet add package OpenFeature.Contrib.Providers.Statsig
13+
dotnet add package OpenFeature.Contrib.Provider.Statsig
1414
```
1515
### Package Manager
1616

1717
```shell
18-
NuGet\Install-Package OpenFeature.Contrib.Providers.Statsig
18+
NuGet\Install-Package OpenFeature.Contrib.Provider.Statsig
1919
```
2020
### Package Reference
2121

2222
```xml
23-
<PackageReference Include="OpenFeature.Contrib.Providers.Statsig" />
23+
<PackageReference Include=" OpenFeature.Contrib.Provider.Statsig" />
2424
```
2525
### Packet cli
2626

2727
```shell
28-
paket add OpenFeature.Contrib.Providers.Statsig
28+
paket add OpenFeature.Contrib.Provider.Statsig
2929
```
3030

3131
### Cake
3232

3333
```shell
34-
// Install OpenFeature.Contrib.Providers.Statsig as a Cake Addin
35-
#addin nuget:?package=OpenFeature.Contrib.Providers.Statsig
34+
// Install OpenFeature.Contrib.Provider.Statsig as a Cake Addin
35+
#addin nuget:?package= OpenFeature.Contrib.Provider.Statsig
3636

37-
// Install OpenFeature.Contrib.Providers.Statsig as a Cake Tool
38-
#tool nuget:?package=OpenFeature.Contrib.Providers.Statsig
37+
// Install OpenFeature.Contrib.Provider.Statsig as a Cake Tool
38+
#tool nuget:?package= OpenFeature.Contrib.Provider.Statsig
3939
```
4040

4141
## Using the Statsig Provider with the OpenFeature SDK
@@ -44,7 +44,7 @@ The following example shows how to use the Statsig provider with the OpenFeature
4444

4545
```csharp
4646
using OpenFeature;
47-
using OpenFeature.Contrib.Providers.Statsig;
47+
using OpenFeature.Contrib.Provider.Statsig;
4848
using System;
4949

5050
StatsigProvider statsigProvider = new StatsigProvider("#YOUR-SDK-KEY#");

Diff for: src/OpenFeature.Contrib.Providers.Statsig/StatsigProvider.cs

+3-6
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,20 @@ public sealed class StatsigProvider : FeatureProvider
2424
volatile bool initialized = false;
2525
private readonly Metadata _providerMetadata = new Metadata("Statsig provider");
2626
private readonly string _sdkKey = "secret-"; //Dummy sdk key that works with local mode
27-
private readonly StatsigServerOptions _options;
2827
internal readonly ServerDriver ServerDriver;
2928

3029
/// <summary>
3130
/// Creates new instance of <see cref="StatsigProvider"/>
3231
/// </summary>
3332
/// <param name="sdkKey">SDK Key to access Statsig.</param>
34-
/// <param name="configurationAction">The action used to configure the client.</param>
35-
public StatsigProvider(string sdkKey = null, Action<StatsigServerOptions> configurationAction = null)
33+
/// <param name="statsigServerOptions">The StatsigServerOptions to configure the provider.</param>
34+
public StatsigProvider(string sdkKey = null, StatsigServerOptions statsigServerOptions = null)
3635
{
3736
if (sdkKey != null)
3837
{
3938
_sdkKey = sdkKey;
4039
}
41-
_options = new StatsigServerOptions();
42-
configurationAction?.Invoke(_options);
43-
ServerDriver = new ServerDriver(_sdkKey, _options);
40+
ServerDriver = new ServerDriver(_sdkKey, statsigServerOptions);
4441
}
4542

4643
/// <inheritdoc/>

Diff for: test/OpenFeature.Contrib.Providers.Statsig.Test/StatsigProviderTest.cs

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using OpenFeature.Model;
55
using System.Threading.Tasks;
66
using Xunit;
7+
using Statsig;
78
namespace OpenFeature.Contrib.Providers.Statsig.Test;
89

910
public class StatsigProviderTest
@@ -12,7 +13,7 @@ public class StatsigProviderTest
1213

1314
public StatsigProviderTest()
1415
{
15-
statsigProvider = new StatsigProvider("secret-", x => x.LocalMode = true);
16+
statsigProvider = new StatsigProvider("secret-", new StatsigServerOptions() { LocalMode = true });
1617
}
1718

1819
[Fact]

0 commit comments

Comments
 (0)