Fix code. Added unit tests.

Author: askpt

src/OpenFeature/Model/FlagMetadata.cs

@@ -41,7 +41,7 @@ public FlagMetadata() : this([])
             return null;
         }
 
-        return value as string ?? throw new InvalidCastException($"Cannot cast {value?.GetType().ToString() ?? "Nullable"} to {typeof(string)}");
+        return value as string ?? throw new InvalidCastException($"Cannot cast {value?.GetType()} to {typeof(string)}");
     }
 
     private T? GetValue<T>(string key) where T : struct
@@ -52,6 +52,6 @@ public FlagMetadata() : this([])
             return null;
         }
 
-        return value is T tValue ? tValue : throw new InvalidCastException($"Cannot cast {value?.GetType().ToString() ?? "Nullable"} to {typeof(T)}");
+        return value is T tValue ? tValue : throw new InvalidCastException($"Cannot cast {value?.GetType()} to {typeof(T)}");
     }
 }

test/OpenFeature.Tests/FlagMetadataTest.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using OpenFeature.Model;
 using Xunit;
@@ -10,8 +11,7 @@ public class FlagMetadataTest
         public void GetBool_Should_Return_Null_If_Key_Not_Found()
         {
             // Arrange
-            var metadata = new Dictionary<string, object>();
-            var flagMetadata = new FlagMetadata(metadata);
+            var flagMetadata = new FlagMetadata();
 
             // Act
             var result = flagMetadata.GetBool("nonexistentKey");
@@ -26,7 +26,9 @@ public void GetBool_Should_Return_Value_If_Key_Found()
             // Arrange
             var metadata = new Dictionary<string, object>
             {
-                { "boolKey", true }
+                {
+                    "boolKey", true
+                }
             };
             var flagMetadata = new FlagMetadata(metadata);
 
@@ -38,12 +40,31 @@ public void GetBool_Should_Return_Value_If_Key_Found()
         }
 
         [Fact]
-        public void GetInt_Should_Return_Null_If_Key_Not_Found()
+        public void GetBool_Should_Throw_Value_Is_Invalid()
         {
             // Arrange
-            var metadata = new Dictionary<string, object>();
+            var metadata = new Dictionary<string, object>
+            {
+                {
+                    "wrongKey", "11a"
+                }
+            };
             var flagMetadata = new FlagMetadata(metadata);
 
+            // Act
+            var exception = Assert.Throws<InvalidCastException>(() => flagMetadata.GetBool("wrongKey"));
+
+            // Assert
+            Assert.NotNull(exception);
+            Assert.Equal("Cannot cast System.String to System.Boolean", exception.Message);
+        }
+
+        [Fact]
+        public void GetInt_Should_Return_Null_If_Key_Not_Found()
+        {
+            // Arrange
+            var flagMetadata = new FlagMetadata();
+
             // Act
             var result = flagMetadata.GetInt("nonexistentKey");
 
@@ -72,12 +93,31 @@ public void GetInt_Should_Return_Value_If_Key_Found()
         }
 
         [Fact]
-        public void GetDouble_Should_Return_Null_If_Key_Not_Found()
+        public void GetInt_Should_Throw_Value_Is_Invalid()
         {
             // Arrange
-            var metadata = new Dictionary<string, object>();
+            var metadata = new Dictionary<string, object>
+            {
+                {
+                    "wrongKey", "11a"
+                }
+            };
             var flagMetadata = new FlagMetadata(metadata);
 
+            // Act
+            var exception = Assert.Throws<InvalidCastException>(() => flagMetadata.GetInt("wrongKey"));
+
+            // Assert
+            Assert.NotNull(exception);
+            Assert.Equal("Cannot cast System.String to System.Int32", exception.Message);
+        }
+
+        [Fact]
+        public void GetDouble_Should_Return_Null_If_Key_Not_Found()
+        {
+            // Arrange
+            var flagMetadata = new FlagMetadata();
+
             // Act
             var result = flagMetadata.GetDouble("nonexistentKey");
 
@@ -106,12 +146,31 @@ public void GetDouble_Should_Return_Value_If_Key_Found()
         }
 
         [Fact]
-        public void GetString_Should_Return_Null_If_Key_Not_Found()
+        public void GetDouble_Should_Throw_Value_Is_Invalid()
         {
             // Arrange
-            var metadata = new Dictionary<string, object>();
+            var metadata = new Dictionary<string, object>
+            {
+                {
+                    "wrongKey", "11a"
+                }
+            };
             var flagMetadata = new FlagMetadata(metadata);
 
+            // Act
+            var exception = Assert.Throws<InvalidCastException>(() => flagMetadata.GetDouble("wrongKey"));
+
+            // Assert
+            Assert.NotNull(exception);
+            Assert.Equal("Cannot cast System.String to System.Double", exception.Message);
+        }
+
+        [Fact]
+        public void GetString_Should_Return_Null_If_Key_Not_Found()
+        {
+            // Arrange
+            var flagMetadata = new FlagMetadata();
+
             // Act
             var result = flagMetadata.GetString("nonexistentKey");
 
@@ -138,5 +197,25 @@ public void GetString_Should_Return_Value_If_Key_Found()
             Assert.NotNull(result);
             Assert.Equal("11", result);
         }
+
+        [Fact]
+        public void GetString_Should_Throw_Value_Is_Invalid()
+        {
+            // Arrange
+            var metadata = new Dictionary<string, object>
+            {
+                {
+                    "wrongKey", new object()
+                }
+            };
+            var flagMetadata = new FlagMetadata(metadata);
+
+            // Act
+            var exception = Assert.Throws<InvalidCastException>(() => flagMetadata.GetString("wrongKey"));
+
+            // Assert
+            Assert.NotNull(exception);
+            Assert.Equal("Cannot cast System.Object to System.String", exception.Message);
+        }
     }
 }