Skip to content

Commit 1d523cf

Browse files
benjirobenjiro
authored
test: Upgrade test deps (#221)
## This PR Upgrade all test deps - Autofixture 4.17 -> 4.18.1 - coverlet 3.1.2 -> 6.0.0 - FluentAssertions 6.7.0 -> 6.12.0 - MSN.Test.Sdk 17.2.0 -> 17.9.0 - NSubstitue 5 -> 5.1 - FlagD Provider 0.1.5 -> 0.1.8 - Xunit 2.4.1 -> 2.6.6 ### Related Issues Fixes #197 Signed-off-by: Benjamin Evenson <[email protected]>
1 parent cc6c404 commit 1d523cf

File tree

5 files changed

+41
-40
lines changed

5 files changed

+41
-40
lines changed

‎Directory.Packages.props

+6-6
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,20 @@
1212
</ItemGroup>
1313

1414
<ItemGroup Label="test">
15-
<PackageVersion Include="AutoFixture" Version="4.17.0" />
15+
<PackageVersion Include="AutoFixture" Version="4.18.1" />
1616
<PackageVersion Include="BenchmarkDotNet" Version="0.13.1" />
17-
<PackageVersion Include="coverlet.collector" Version="3.1.2" />
18-
<PackageVersion Include="coverlet.msbuild" Version="3.1.2" />
17+
<PackageVersion Include="coverlet.collector" Version="6.0.0" />
18+
<PackageVersion Include="coverlet.msbuild" Version="6.0.0" />
1919
<PackageVersion Include="FluentAssertions" Version="6.12.0" />
2020
<PackageVersion Include="GitHubActionsTestLogger" Version="2.3.3" />
21-
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
21+
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
2222
<PackageVersion Include="NSubstitute" Version="5.1.0" />
2323
<PackageVersion Include="OpenFeature.Contrib.Providers.Flagd" Version="0.1.8" />
2424
<PackageVersion Include="SpecFlow" Version="3.9.74" />
2525
<PackageVersion Include="SpecFlow.Tools.MsBuild.Generation" Version="3.9.74" />
2626
<PackageVersion Include="SpecFlow.xUnit" Version="3.9.74" />
27-
<PackageVersion Include="xunit" Version="[2.4.1, 3.0)" />
28-
<PackageVersion Include="xunit.runner.visualstudio" Version="[2.4.3, 3.0)" />
27+
<PackageVersion Include="xunit" Version="2.6.6" />
28+
<PackageVersion Include="xunit.runner.visualstudio" Version="2.5.6" />
2929
</ItemGroup>
3030

3131
<ItemGroup Condition="'$(OS)' == 'Unix'">

‎test/OpenFeature.Tests/OpenFeatureTests.cs

+28-26
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using System.Diagnostics.CodeAnalysis;
12
using System.Linq;
23
using System.Threading.Tasks;
34
using FluentAssertions;
@@ -9,6 +10,7 @@
910

1011
namespace OpenFeature.Tests
1112
{
13+
[SuppressMessage("Reliability", "CA2007:Consider calling ConfigureAwait on the awaited task")]
1214
public class OpenFeatureTests : ClearOpenFeatureInstanceFixture
1315
{
1416
[Fact]
@@ -28,14 +30,14 @@ public async Task OpenFeature_Should_Initialize_Provider()
2830
var providerMockDefault = Substitute.For<FeatureProvider>();
2931
providerMockDefault.GetStatus().Returns(ProviderStatus.NotReady);
3032

31-
await Api.Instance.SetProviderAsync(providerMockDefault).ConfigureAwait(false);
32-
await providerMockDefault.Received(1).Initialize(Api.Instance.GetContext()).ConfigureAwait(false);
33+
await Api.Instance.SetProviderAsync(providerMockDefault);
34+
await providerMockDefault.Received(1).Initialize(Api.Instance.GetContext());
3335

3436
var providerMockNamed = Substitute.For<FeatureProvider>();
3537
providerMockNamed.GetStatus().Returns(ProviderStatus.NotReady);
3638

37-
await Api.Instance.SetProviderAsync("the-name", providerMockNamed).ConfigureAwait(false);
38-
await providerMockNamed.Received(1).Initialize(Api.Instance.GetContext()).ConfigureAwait(false);
39+
await Api.Instance.SetProviderAsync("the-name", providerMockNamed);
40+
await providerMockNamed.Received(1).Initialize(Api.Instance.GetContext());
3941
}
4042

4143
[Fact]
@@ -46,28 +48,28 @@ public async Task OpenFeature_Should_Shutdown_Unused_Provider()
4648
var providerA = Substitute.For<FeatureProvider>();
4749
providerA.GetStatus().Returns(ProviderStatus.NotReady);
4850

49-
await Api.Instance.SetProviderAsync(providerA).ConfigureAwait(false);
50-
await providerA.Received(1).Initialize(Api.Instance.GetContext()).ConfigureAwait(false);
51+
await Api.Instance.SetProviderAsync(providerA);
52+
await providerA.Received(1).Initialize(Api.Instance.GetContext());
5153

5254
var providerB = Substitute.For<FeatureProvider>();
5355
providerB.GetStatus().Returns(ProviderStatus.NotReady);
5456

55-
await Api.Instance.SetProviderAsync(providerB).ConfigureAwait(false);
56-
await providerB.Received(1).Initialize(Api.Instance.GetContext()).ConfigureAwait(false);
57-
await providerA.Received(1).Shutdown().ConfigureAwait(false);
57+
await Api.Instance.SetProviderAsync(providerB);
58+
await providerB.Received(1).Initialize(Api.Instance.GetContext());
59+
await providerA.Received(1).Shutdown();
5860

5961
var providerC = Substitute.For<FeatureProvider>();
6062
providerC.GetStatus().Returns(ProviderStatus.NotReady);
6163

62-
await Api.Instance.SetProviderAsync("named", providerC).ConfigureAwait(false);
63-
await providerC.Received(1).Initialize(Api.Instance.GetContext()).ConfigureAwait(false);
64+
await Api.Instance.SetProviderAsync("named", providerC);
65+
await providerC.Received(1).Initialize(Api.Instance.GetContext());
6466

6567
var providerD = Substitute.For<FeatureProvider>();
6668
providerD.GetStatus().Returns(ProviderStatus.NotReady);
6769

68-
await Api.Instance.SetProviderAsync("named", providerD).ConfigureAwait(false);
69-
await providerD.Received(1).Initialize(Api.Instance.GetContext()).ConfigureAwait(false);
70-
await providerC.Received(1).Shutdown().ConfigureAwait(false);
70+
await Api.Instance.SetProviderAsync("named", providerD);
71+
await providerD.Received(1).Initialize(Api.Instance.GetContext());
72+
await providerC.Received(1).Shutdown();
7173
}
7274

7375
[Fact]
@@ -80,13 +82,13 @@ public async Task OpenFeature_Should_Support_Shutdown()
8082
var providerB = Substitute.For<FeatureProvider>();
8183
providerB.GetStatus().Returns(ProviderStatus.NotReady);
8284

83-
await Api.Instance.SetProviderAsync(providerA).ConfigureAwait(false);
84-
await Api.Instance.SetProviderAsync("named", providerB).ConfigureAwait(false);
85+
await Api.Instance.SetProviderAsync(providerA);
86+
await Api.Instance.SetProviderAsync("named", providerB);
8587

86-
await Api.Instance.Shutdown().ConfigureAwait(false);
88+
await Api.Instance.Shutdown();
8789

88-
await providerA.Received(1).Shutdown().ConfigureAwait(false);
89-
await providerB.Received(1).Shutdown().ConfigureAwait(false);
90+
await providerA.Received(1).Shutdown();
91+
await providerB.Received(1).Shutdown();
9092
}
9193

9294
[Fact]
@@ -95,8 +97,8 @@ public async Task OpenFeature_Should_Not_Change_Named_Providers_When_Setting_Def
9597
{
9698
var openFeature = Api.Instance;
9799

98-
await openFeature.SetProviderAsync(new NoOpFeatureProvider()).ConfigureAwait(false);
99-
await openFeature.SetProviderAsync(TestProvider.DefaultName, new TestProvider()).ConfigureAwait(false);
100+
await openFeature.SetProviderAsync(new NoOpFeatureProvider());
101+
await openFeature.SetProviderAsync(TestProvider.DefaultName, new TestProvider());
100102

101103
var defaultClient = openFeature.GetProviderMetadata();
102104
var namedClient = openFeature.GetProviderMetadata(TestProvider.DefaultName);
@@ -111,7 +113,7 @@ public async Task OpenFeature_Should_Set_Default_Provide_When_No_Name_Provided()
111113
{
112114
var openFeature = Api.Instance;
113115

114-
await openFeature.SetProviderAsync(new TestProvider()).ConfigureAwait(false);
116+
await openFeature.SetProviderAsync(new TestProvider());
115117

116118
var defaultClient = openFeature.GetProviderMetadata();
117119

@@ -178,9 +180,9 @@ public void OpenFeature_Should_Add_Hooks()
178180

179181
[Fact]
180182
[Specification("1.1.5", "The API MUST provide a function for retrieving the metadata field of the configured `provider`.")]
181-
public void OpenFeature_Should_Get_Metadata()
183+
public async Task OpenFeature_Should_Get_Metadata()
182184
{
183-
Api.Instance.SetProviderAsync(new NoOpFeatureProvider()).Wait();
185+
await Api.Instance.SetProviderAsync(new NoOpFeatureProvider());
184186
var openFeature = Api.Instance;
185187
var metadata = openFeature.GetProviderMetadata();
186188

@@ -239,8 +241,8 @@ public async Task OpenFeature_Should_Allow_Multiple_Client_Mapping()
239241
client1.GetMetadata().Name.Should().Be("client1");
240242
client2.GetMetadata().Name.Should().Be("client2");
241243

242-
client1.GetBooleanValue("test", false).Result.Should().BeTrue();
243-
client2.GetBooleanValue("test", false).Result.Should().BeFalse();
244+
(await client1.GetBooleanValue("test", false)).Should().BeTrue();
245+
(await client2.GetBooleanValue("test", false)).Should().BeFalse();
244246
}
245247
}
246248
}

‎test/OpenFeature.Tests/StructureTests.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public void Values_Should_Return_Values()
8989

9090
var structure = Structure.Builder()
9191
.Set(KEY, VAL).Build();
92-
Assert.Equal(1, structure.Values.Count);
92+
Assert.Single(structure.Values);
9393
}
9494

9595
[Fact]
@@ -100,7 +100,7 @@ public void Keys_Should_Return_Keys()
100100

101101
var structure = Structure.Builder()
102102
.Set(KEY, VAL).Build();
103-
Assert.Equal(1, structure.Keys.Count);
103+
Assert.Single(structure.Keys);
104104
Assert.Equal(0, structure.Keys.IndexOf(KEY));
105105
}
106106

‎test/OpenFeature.Tests/TestUtilsTest.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,22 @@
11
using System;
2-
using System.Collections.Generic;
3-
using System.Collections.Immutable;
4-
using OpenFeature.Model;
2+
using System.Diagnostics.CodeAnalysis;
53
using Xunit;
64

75
namespace OpenFeature.Tests
86
{
7+
[SuppressMessage("Reliability", "CA2007:Consider calling ConfigureAwait on the awaited task")]
98
public class TestUtilsTest
109
{
1110
[Fact]
1211
public async void Should_Fail_If_Assertion_Fails()
1312
{
14-
await Assert.ThrowsAnyAsync<Exception>(() => Utils.AssertUntilAsync(_ => Assert.True(1.Equals(2)), 100, 10)).ConfigureAwait(false);
13+
await Assert.ThrowsAnyAsync<Exception>(() => Utils.AssertUntilAsync(_ => Assert.True(1.Equals(2)), 100, 10));
1514
}
1615

1716
[Fact]
1817
public async void Should_Pass_If_Assertion_Fails()
1918
{
20-
await Utils.AssertUntilAsync(_ => Assert.True(1.Equals(1))).ConfigureAwait(false);
19+
await Utils.AssertUntilAsync(_ => Assert.True(1.Equals(1)));
2120
}
2221
}
2322
}

‎test/OpenFeature.Tests/ValueTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public void Int_Object_Arg_Should_Contain_Object()
5353
}
5454
catch (Exception)
5555
{
56-
Assert.True(false, "Expected no exception.");
56+
Assert.Fail("Expected no exception.");
5757
}
5858
}
5959

0 commit comments

Comments
 (0)