You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: Address issue with newline characters when running Logging Hook Unit Tests on linux (#374)
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->
## This PR
<!-- add the description of the PR here -->
I noticed when I ran the LoggingHook unit tests on a WSL Ubuntu instance
the some tests fails due to new line characters. It appears I never
normalized or excluded newline characters when asserting equal

I also removed the `Assert.Contains` snippets as the content and layout
of the log message is asserted in the other tests. This Assert method
does not have an overload for ignoring new line characters
I assume the GitHub CI runner may be ignore the line endings by default?
### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->
### Notes
<!-- any additional notes for this PR -->
### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->
### How to test
<!-- if applicable, add testing instructions under this section -->
Signed-off-by: Kyle Julian <[email protected]>
0 commit comments