-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] add readme to published package #138
Comments
@toddbaert and @beeme1mr it seems my PR didn't fix the issue. Could you please reopen this task? |
I was reading this article and it seems we have some badges that are not in the Nuget whitelist: https://learn.microsoft.com/en-us/NuGet/nuget-org/package-readme-on-nuget-org#allowed-domains-for-images-and-badges Since I am not the package owner, it is hard to understand what is going on under the hood. Could someone help me with this bit here? |
Hey @askpt, here's what I discovered. First, the readme isn't live on NuGet yet because we haven't released an update. We were waiting for support for events before releasing an update. That feature was just added, so a release should happen soon. I also spent some time looking into the markdown restrictions that NuGet has. Unfortunately, they don't support some of the HTML elements we use and they're rendered as plain text. Here's a GitHub issue that shows all the missing features. It also looks like I think the biggest issue is the lack of HTML support in NuGet. We may want to write a script that strips HTML. We already have What do you think @askpt? FYI @toddbaert |
Sorry @beeme1mr got confused between the contrib and SDK packages. I thought there was a new version for the SDK with the PR that introduces the NuGet feature. |
I'll submit a request to add the domain. |
As suspected, the HTML is not rendered correctly. We need to revisit this issue to fix them: https://www.nuget.org/packages/OpenFeature |
😩 |
Change in the documentation
We currently don't have a readme being published.
We can do follow these steps to do that: https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/#add-a-readme-to-your-package
The text was updated successfully, but these errors were encountered: