Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] add readme to published package #138

Closed
toddbaert opened this issue Jul 14, 2023 · 8 comments · Fixed by #164 or #199
Closed

[DOC] add readme to published package #138

toddbaert opened this issue Jul 14, 2023 · 8 comments · Fixed by #164 or #199
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@toddbaert
Copy link
Member

Change in the documentation

We currently don't have a readme being published.

We can do follow these steps to do that: https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/#add-a-readme-to-your-package

@toddbaert toddbaert added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Jul 14, 2023
@askpt
Copy link
Member

askpt commented Jan 11, 2024

@toddbaert and @beeme1mr it seems my PR didn't fix the issue. Could you please reopen this task?

@beeme1mr beeme1mr reopened this Jan 11, 2024
@beeme1mr beeme1mr assigned beeme1mr and askpt and unassigned beeme1mr Jan 11, 2024
@askpt
Copy link
Member

askpt commented Jan 16, 2024

I was reading this article and it seems we have some badges that are not in the Nuget whitelist: https://learn.microsoft.com/en-us/NuGet/nuget-org/package-readme-on-nuget-org#allowed-domains-for-images-and-badges

Since I am not the package owner, it is hard to understand what is going on under the hood. Could someone help me with this bit here?
@beeme1mr @toddbaert

@beeme1mr
Copy link
Member

Hey @askpt, here's what I discovered. First, the readme isn't live on NuGet yet because we haven't released an update. We were waiting for support for events before releasing an update. That feature was just added, so a release should happen soon.

I also spent some time looking into the markdown restrictions that NuGet has. Unfortunately, they don't support some of the HTML elements we use and they're rendered as plain text. Here's a GitHub issue that shows all the missing features. It also looks like https://bestpractices.coreinfrastructure.org/projects/6250/badge will be blocked but the NuGet team has a process to get a new domain added to their allow list.

I think the biggest issue is the lack of HTML support in NuGet. We may want to write a script that strips HTML. We already have x-hide-in-docs-start and e x-hide-in-docs-end tags that could be used to remove unwanted content.

What do you think @askpt? FYI @toddbaert

@askpt
Copy link
Member

askpt commented Jan 16, 2024

Sorry @beeme1mr got confused between the contrib and SDK packages. I thought there was a new version for the SDK with the PR that introduces the NuGet feature.
In relation to your point, might be useful looking into a new tag just to show/hide when published to the NuGet.
For the badges, you're right. Might be worth trying to have the other team to add the domains to the whitelist.

@beeme1mr
Copy link
Member

I'll submit a request to add the domain.

@beeme1mr
Copy link
Member

NuGet/NuGetGallery#9778

@beeme1mr beeme1mr reopened this Jan 16, 2024
@askpt
Copy link
Member

askpt commented Jan 23, 2024

As suspected, the HTML is not rendered correctly. We need to revisit this issue to fix them: https://www.nuget.org/packages/OpenFeature

@toddbaert
Copy link
Member Author

As suspected, the HTML is not rendered correctly. We need to revisit this issue to fix them: https://www.nuget.org/packages/OpenFeature

😩

@askpt askpt linked a pull request Jan 23, 2024 that will close this issue
@askpt askpt closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants