option to override http.Client for OFREP communication

Signed-off-by: Kavindu Dodanduwa <[email protected]>

Author: Kavindu-Dodan

providers/ofrep/README.md

@@ -32,8 +32,9 @@ You can configure the provider using following configuration options,
 
 | Configuration option | Details                                                                                                                 |
 |----------------------|-------------------------------------------------------------------------------------------------------------------------|
-| WithBearerToken      | Set the token to be used with "Bearer" HTTP Authorization schema                                                        |
 | WithApiKeyAuth       | Set the token to be used with "X-API-Key" header                                                                        |
+| WithBearerToken      | Set the token to be used with "Bearer" HTTP Authorization schema                                                        |
+| WithClient           | Provider a custom, pre-configured http.Client for OFREP service communication                                           |
 | WithHeaderProvider   | Register a custom header provider for OFREP calls. You may utilize this for custom authentication/authorization headers |
 
 

providers/ofrep/internal/outbound/http.go

@@ -17,27 +17,29 @@ const ofrepV1 = "/ofrep/v1/evaluate/flags/"
 type HeaderCallback func() (name string, value string)
 
 type Configuration struct {
-	Callbacks []HeaderCallback
 	BaseURI   string
+	Callbacks []HeaderCallback
+	Client    *http.Client
 }
 
 // Outbound client for http communication
 type Outbound struct {
-	headerProvider []HeaderCallback
 	baseURI        string
-
-	client http.Client
+	client         *http.Client
+	headerProvider []HeaderCallback
 }
 
 func NewHttp(cfg Configuration) *Outbound {
-	client := http.Client{
-		Timeout: 10 * time.Second,
+	if cfg.Client == nil {
+		cfg.Client = &http.Client{
+			Timeout: 10 * time.Second,
+		}
 	}
 
 	return &Outbound{
 		headerProvider: cfg.Callbacks,
 		baseURI:        cfg.BaseURI,
-		client:         client,
+		client:         cfg.Client,
 	}
 }
 

providers/ofrep/provider.go

@@ -3,6 +3,7 @@ package ofrep
 import (
 	"context"
 	"fmt"
+	"net/http"
 
 	"github.com/open-feature/go-sdk-contrib/providers/ofrep/internal/evaluate"
 	"github.com/open-feature/go-sdk-contrib/providers/ofrep/internal/outbound"
@@ -90,3 +91,10 @@ func WithApiKeyAuth(token string) func(*outbound.Configuration) {
 		})
 	}
 }
+
+// WithClient allows to provide a pre-configured http.Client for the communication with the OFREP service
+func WithClient(client *http.Client) func(configuration *outbound.Configuration) {
+	return func(configuration *outbound.Configuration) {
+		configuration.Client = client
+	}
+}

providers/ofrep/provider_test.go

@@ -83,9 +83,15 @@ func TestWiringE2E(t *testing.T) {
 		}
 	}()
 
+	// time for server to be ready
 	<-time.After(3 * time.Second)
 
-	provider := NewProvider(fmt.Sprintf("http://%s", host))
+	// custom client with reduced timeout
+	customClient := &http.Client{
+		Timeout: 1 * time.Second,
+	}
+
+	provider := NewProvider(fmt.Sprintf("http://%s", host), WithClient(customClient))
 	booleanEvaluation := provider.BooleanEvaluation(context.Background(), "flag", false, nil)
 
 	if booleanEvaluation.Value != true {