Skip to content

Commit ac5dbaa

Browse files
fix: rename default variation to keep consistency (#155)
Signed-off-by: Thomas Poignant <[email protected]>
1 parent 5ab613e commit ac5dbaa

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

Diff for: providers/go-feature-flag/pkg/provider.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ func evaluateWithRelayProxy[T model.JsonType](provider *Provider, ctx context.Co
335335
Value: defaultValue,
336336
ProviderResolutionDetail: of.ProviderResolutionDetail{
337337
Reason: of.DisabledReason,
338-
Variant: "defaultSdk",
338+
Variant: "SdkDefault",
339339
},
340340
}
341341
}

Diff for: providers/go-feature-flag/pkg/provider_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func TestProvider_BooleanEvaluation(t *testing.T) {
9999
FlagKey: "disabled_bool",
100100
FlagType: of.Boolean,
101101
ResolutionDetail: of.ResolutionDetail{
102-
Variant: "defaultSdk",
102+
Variant: "SdkDefault",
103103
Reason: of.DisabledReason,
104104
ErrorCode: "",
105105
ErrorMessage: "",
@@ -282,7 +282,7 @@ func TestProvider_StringEvaluation(t *testing.T) {
282282
FlagKey: "disabled_string",
283283
FlagType: of.String,
284284
ResolutionDetail: of.ResolutionDetail{
285-
Variant: "defaultSdk",
285+
Variant: "SdkDefault",
286286
Reason: of.DisabledReason,
287287
ErrorCode: "",
288288
ErrorMessage: "",
@@ -404,7 +404,7 @@ func TestProvider_FloatEvaluation(t *testing.T) {
404404
FlagKey: "disabled_float",
405405
FlagType: of.Float,
406406
ResolutionDetail: of.ResolutionDetail{
407-
Variant: "defaultSdk",
407+
Variant: "SdkDefault",
408408
Reason: of.DisabledReason,
409409
ErrorCode: "",
410410
ErrorMessage: "",
@@ -526,7 +526,7 @@ func TestProvider_IntEvaluation(t *testing.T) {
526526
FlagKey: "disabled_int",
527527
FlagType: of.Int,
528528
ResolutionDetail: of.ResolutionDetail{
529-
Variant: "defaultSdk",
529+
Variant: "SdkDefault",
530530
Reason: of.DisabledReason,
531531
ErrorCode: "",
532532
ErrorMessage: "",
@@ -654,7 +654,7 @@ func TestProvider_ObjectEvaluation(t *testing.T) {
654654
FlagKey: "disabled_int",
655655
FlagType: of.Object,
656656
ResolutionDetail: of.ResolutionDetail{
657-
Variant: "defaultSdk",
657+
Variant: "SdkDefault",
658658
Reason: of.DisabledReason,
659659
ErrorCode: "",
660660
ErrorMessage: "",

Diff for: providers/go-feature-flag/testutils/mock_responses/disabled_bool.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"trackEvents": true,
3-
"variationType": "defaultSdk",
3+
"variationType": "SdkDefault",
44
"failed": false,
55
"version": "",
66
"reason": "DISABLED",

Diff for: providers/go-feature-flag/testutils/mock_responses/disabled_float.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"trackEvents": true,
3-
"variationType": "defaultSdk",
3+
"variationType": "SdkDefault",
44
"failed": false,
55
"version": "",
66
"reason": "DISABLED",

Diff for: providers/go-feature-flag/testutils/mock_responses/disabled_int.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"trackEvents": true,
3-
"variationType": "defaultSdk",
3+
"variationType": "SdkDefault",
44
"failed": false,
55
"version": "",
66
"reason": "DISABLED",

Diff for: providers/go-feature-flag/testutils/mock_responses/disabled_string.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"trackEvents": true,
3-
"variationType": "defaultSdk",
3+
"variationType": "SdkDefault",
44
"failed": false,
55
"version": "",
66
"reason": "DISABLED",

0 commit comments

Comments
 (0)