Skip to content

feat!: use new eval/sync protos (requires flagd v0.7.3+) #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2024
Merged

feat!: use new eval/sync protos (requires flagd v0.7.3+) #451

merged 1 commit into from
Feb 22, 2024

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Feb 13, 2024 •
edited by toddbaert
Loading

This PR

  • updates protos: (evaluation and sync)
  • bumped a few too-old dependencies --> I can undo the change if it is too much 😸
  • move to go 1.21

@toddbaert
Copy link
Member

@RealAnna the new version of flagd-core is released with your changes, you should be able to absorb them here now.

@RealAnna RealAnna force-pushed the proto-up branch 2 times, most recently from 7aa37e9 to 8d899c2 Compare February 21, 2024 12:51
@github-actions github-actions bot requested a review from markphelps February 21, 2024 13:44
@RealAnna
Copy link
Contributor Author

RealAnna commented Feb 21, 2024 •
edited
Loading

@toddbaert should we mark this as a breaking change as well? 🤔

@RealAnna RealAnna changed the title chore: up proto feat!: use new proto Feb 22, 2024
@RealAnna RealAnna marked this pull request as ready for review February 22, 2024 15:07
@RealAnna RealAnna requested a review from a team as a code owner February 22, 2024 15:07
@toddbaert toddbaert changed the title feat!: use new proto feat!: use new eval/sync protos (requires flagd v0.7.3+) Feb 22, 2024
toddbaert
toddbaert approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking on this pain, Anna. Well done!

(I've updated the title to exact match the one we used in Java/JS).

@toddbaert toddbaert requested a review from beeme1mr February 22, 2024 15:45
@toddbaert toddbaert merged commit 308bba1 into open-feature:main Feb 22, 2024
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
Merged
@toddbaert toddbaert mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@toddbaert toddbaert toddbaert approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

@beeme1mr beeme1mr Awaiting requested review from beeme1mr

Assignees

@bacherfl bacherfl

@Kavindu-Dodan Kavindu-Dodan

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RealAnna @toddbaert @Kavindu-Dodan @markphelps @bacherfl @sighphyre @liran2000