fix(ofrep): close http response body after using it #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the memory leak when using http client. It also cleanups few tests and typos. Signed-off-by: Roman Dmytrenko <[email protected]>
erka
force-pushed
the
ofrep-close-resp-body
branch
from
74d1d44 to
68f0e34
Compare
beeme1mr
approved these changes
Aug 22, 2024
thomaspoignant
approved these changes
Aug 22, 2024
|
Hey @beeme1mr @thomaspoignant. Is there anything else preventing this PR from being merged? |
|
@erka no nothing. |
|
@thomaspoignant thank you! |
|
It is released ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Notes
Follow-up Tasks
How to test