Skip to content

fix(flagd): Fixed possible nil pointer exception with svcMetadata in service.go #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix(flagd): Fixed possible nil pointer exception with svcMetadata in service.go #634

merged 1 commit into from
Feb 21, 2025

Conversation

cupofcat
Copy link
Contributor

This PR

  • fixes potential nil pointer exception when using WithProviderID without WithSelectorID
  • adds tests to catch that in the future

@cupofcat
fix(flagd): Fixed possible nil pointer exception with svcMetadata in …
94d545c 
…service.go

Change-Id: Ib5478f47bac8d1087b9fe90915c9200e5633cbfe
Signed-off-by: Maks Osowski <[email protected]>
@cupofcat cupofcat requested a review from a team as a code owner February 21, 2025 12:06
@beeme1mr beeme1mr merged commit 50256e9 into open-feature:main Feb 21, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@bacherfl bacherfl Awaiting requested review from bacherfl

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees

@bacherfl bacherfl

@Kavindu-Dodan Kavindu-Dodan

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cupofcat @beeme1mr @bacherfl @Kavindu-Dodan @toddbaert