fix fractional hash calculation

Signed-off-by: Kavindu Dodanduwa <[email protected]>

Author: Kavindu-Dodan

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Fractional.java

@@ -77,10 +77,10 @@ public Object evaluate(List arguments, Object data) throws JsonLogicEvaluationEx
     private static String distributeValue(final String hashKey, final List<FractionProperty> propertyList)
             throws JsonLogicEvaluationException {
         byte[] bytes = hashKey.getBytes(StandardCharsets.UTF_8);
-        double bucket =
-                (Math.abs(Murmur3.hash64(bytes, 0, bytes.length, 0)) * 1.0d / Long.MAX_VALUE) * 100.0d;
+        int mmrHash = Murmur3.hash32(bytes, 0, bytes.length, 0);
+        int bucket = (int) ((Math.abs(mmrHash) * 1.0f / Integer.MAX_VALUE) * 100);
 
-        double bucketSum = 0;
+        int bucketSum = 0;
         for (FractionProperty p : propertyList) {
             bucketSum += p.getPercentage();
 
@@ -96,7 +96,7 @@ private static String distributeValue(final String hashKey, final List<FractionP
     @Getter
     private static class FractionProperty {
         private final String variant;
-        private final double percentage;
+        private final int percentage;
 
         FractionProperty(final Object from) throws JsonLogicException {
             if (!(from instanceof List<?>)) {
@@ -120,7 +120,7 @@ private static class FractionProperty {
             }
 
             variant = (String) array.get(0);
-            percentage = ((Number) array.get(1)).doubleValue();
+            percentage = ((Number) array.get(1)).intValue();
         }
 
     }

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/OperatorTest.java

@@ -54,7 +54,7 @@ void fractionalTestA() throws TargetingRuleException {
         Object evalVariant = OPERATOR.apply("headerColor", targetingRule, new ImmutableContext(ctxData));
 
         // then
-        assertEquals("red", evalVariant);
+        assertEquals("yellow", evalVariant);
     }
 
     @Test
@@ -93,7 +93,46 @@ void fractionalTestB() throws TargetingRuleException {
         Object evalVariant = OPERATOR.apply("headerColor", targetingRule, new ImmutableContext(ctxData));
 
         // then
-        assertEquals("yellow", evalVariant);
+        assertEquals("blue", evalVariant);
+    }
+
+    @Test
+    void fractionalTestC() throws TargetingRuleException {
+        // given
+
+        // fractional rule with email as expression key
+        final String targetingRule = "" +
+                "{\n" +
+                "  \"fractional\": [\n" +
+                "    {\"var\": \"email\"},\n" +
+                "    [\n" +
+                "      \"red\",\n" +
+                "      25\n" +
+                "    ],\n" +
+                "    [\n" +
+                "      \"blue\",\n" +
+                "      25\n" +
+                "    ],\n" +
+                "    [\n" +
+                "      \"green\",\n" +
+                "      25\n" +
+                "    ],\n" +
+                "    [\n" +
+                "      \"yellow\",\n" +
+                "      25\n" +
+                "    ]\n" +
+                "  ]\n" +
+                "}";
+
+        Map<String, Value> ctxData = new HashMap<>();
+        ctxData.put("email", new Value("[email protected]"));
+
+
+        // when
+        Object evalVariant = OPERATOR.apply("headerColor", targetingRule, new ImmutableContext(ctxData));
+
+        // then
+        assertEquals("red", evalVariant);
     }
 
     @Test