Skip to content

Commit 35ebcc4

Browse files
committed
Merge branch 'main' into fix/fixing_missing_selector
2 parents 9fe354f + 34f83c5 commit 35ebcc4

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

Diff for: providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelMonitor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public static void monitorChannelState(
4848
}
4949
}
5050
if (currentState != ConnectivityState.SHUTDOWN) {
51-
log.debug("shutting down grpc channel");
51+
log.debug("continuing to monitor the grpc channel");
5252
// Re-register the state monitor to watch for the next state transition.
5353
monitorChannelState(currentState, channel, onConnectionReady, onConnectionLost);
5454
}

Diff for: providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ void observeEventStream(final BlockingQueue<QueuePayload> writeTo, final AtomicB
120120
// instead of logging and throwing here, retain the exception and handle in the
121121
// stream logic below
122122
metadataException = e;
123+
log.debug("Metadata exception: {}", e.getMessage(), e);
123124
}
124125

125126
while (!shutdown.get()) {
@@ -133,7 +134,10 @@ void observeEventStream(final BlockingQueue<QueuePayload> writeTo, final AtomicB
133134

134135
Throwable streamException = response.getError();
135136
if (streamException != null || metadataException != null) {
136-
log.debug("Exception in GRPC connection");
137+
log.debug(
138+
"Exception in GRPC connection, streamException {}, metadataException {}",
139+
streamException,
140+
metadataException);
137141
if (!writeTo.offer(new QueuePayload(
138142
QueuePayloadType.ERROR, "Error from stream or metadata", metadataResponse))) {
139143
log.error("Failed to convey ERROR status, queue is full");

Diff for: providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunFileTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
@ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "dev.openfeature.contrib.providers.flagd.e2e.steps")
2929
@ConfigurationParameter(key = OBJECT_FACTORY_PROPERTY_NAME, value = "io.cucumber.picocontainer.PicoFactory")
3030
@IncludeTags("file")
31-
@ExcludeTags({"unixsocket", "targetURI", "reconnect", "customCert"})
31+
@ExcludeTags({"unixsocket", "targetURI", "reconnect", "customCert", "events"})
3232
@Testcontainers
3333
public class RunFileTest {
3434

Diff for: providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/RunInProcessTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import org.junit.platform.suite.api.IncludeEngines;
1414
import org.junit.platform.suite.api.IncludeTags;
1515
import org.junit.platform.suite.api.SelectDirectories;
16+
import org.junit.platform.suite.api.SelectFile;
1617
import org.junit.platform.suite.api.Suite;
1718
import org.testcontainers.junit.jupiter.Testcontainers;
1819

@@ -22,9 +23,9 @@
2223
@Order(value = Integer.MAX_VALUE)
2324
@Suite
2425
@IncludeEngines("cucumber")
25-
@SelectDirectories("test-harness/gherkin")
26+
//@SelectDirectories("test-harness/gherkin")
2627
// if you want to run just one feature file, use the following line instead of @SelectDirectories
27-
// @SelectFile("test-harness/gherkin/connection.feature")
28+
@SelectFile("test-harness/gherkin/selector.feature")
2829
@ConfigurationParameter(key = PLUGIN_PROPERTY_NAME, value = "pretty")
2930
@ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "dev.openfeature.contrib.providers.flagd.e2e.steps")
3031
@ConfigurationParameter(key = OBJECT_FACTORY_PROPERTY_NAME, value = "io.cucumber.picocontainer.PicoFactory")

Diff for: providers/flagd/test-harness

0 commit comments

Comments
 (0)