Skip to content

Commit 375c205

Browse files
committed
doc updates and added test coverage
Signed-off-by: Pradeep <[email protected]>
1 parent ced0899 commit 375c205

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

Diff for: providers/flagd/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ Given below are the supported configurations:
112112
| maxEventStreamRetries | FLAGD_MAX_EVENT_STREAM_RETRIES | int | 5 | rpc |
113113
| retryBackoffMs | FLAGD_RETRY_BACKOFF_MS | int | 1000 | rpc |
114114
| offlineFlagSourcePath | FLAGD_OFFLINE_FLAG_SOURCE_PATH | String | null | in-process |
115+
| authority | FLAGD_AUTHORITY_OVERRIDE | String | null | rpc & in-process |
115116

116117
> [!NOTE]
117118
> Some configurations are only applicable for RPC resolver.

Diff for: providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdOptionsTest.java

+12
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ void TestDefaults() {
3434
assertNull(builder.getOfflineFlagSourcePath());
3535
assertEquals(Resolver.RPC, builder.getResolverType());
3636
assertEquals(0, builder.getKeepAlive());
37+
assertNull(builder.getAuthority());
3738
}
3839

3940
@Test
@@ -55,6 +56,7 @@ void TestBuilderOptions() {
5556
.customConnector(connector)
5657
.resolverType(Resolver.IN_PROCESS)
5758
.keepAlive(1000)
59+
.authority("test.service")
5860
.build();
5961

6062
assertEquals("https://hosted-flagd", flagdOptions.getHost());
@@ -70,6 +72,7 @@ void TestBuilderOptions() {
7072
assertEquals(connector, flagdOptions.getCustomConnector());
7173
assertEquals(Resolver.IN_PROCESS, flagdOptions.getResolverType());
7274
assertEquals(1000, flagdOptions.getKeepAlive());
75+
assertEquals("test.service", flagdOptions.getAuthority());
7376
}
7477

7578

@@ -187,4 +190,13 @@ void testRpcProviderFromEnv_portConfigured_usesConfiguredPort() {
187190
assertThat(flagdOptions.getPort()).isEqualTo(1534);
188191

189192
}
193+
194+
195+
@Test
196+
@SetEnvironmentVariable(key = AUTHORITY_OVERRIDE, value = "test.service")
197+
void testAuthorityOverrideFromEnv() {
198+
FlagdOptions flagdOptions = FlagdOptions.builder().build();
199+
200+
assertThat(flagdOptions.getAuthority()).isEqualTo("test.service");
201+
}
190202
}

0 commit comments

Comments
 (0)