chore: checkstyle issues

Signed-off-by: Simon Schrottner <[email protected]>

Author: aepfli

Diff for: tools/junit-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/Flag.java

@@ -2,17 +2,34 @@
 
 import org.junit.jupiter.api.extension.ExtendWith;
 
-import java.lang.annotation.*;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Repeatable;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
 
+/**
+ * Annotation for Flag Configuration for the default domain.
+ * Can be used as a standalone flag configuration but also within {@link OpenFeature}.
+ */
 @Target({ElementType.METHOD, ElementType.TYPE})
 @Retention(RetentionPolicy.RUNTIME)
 @Repeatable(Flags.class)
 @ExtendWith(OpenFeatureExtension.class)
 public @interface Flag {
+    /**
+     * The key of the FeatureFlag.
+     */
     String name();
 
+    /**
+     * The value of the FeatureFlag.
+     */
     String value();
 
+    /**
+     * The type of the FeatureFlag.
+     */
     Class<?> valueType() default Boolean.class;
 }
 

Diff for: tools/junit-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/Flags.java

@@ -7,10 +7,16 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
+/**
+ * Collection of {@link Flag} configurations.
+ */
 @Target({ElementType.METHOD, ElementType.TYPE})
 @Retention(RetentionPolicy.RUNTIME)
 @ExtendWith(OpenFeatureExtension.class)
 public @interface Flags {
+    /**
+     * Collection of {@link Flag} configurations.
+     */
     Flag[] value() default {};
 }
 

Diff for: tools/junit-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/OpenFeature.java

@@ -1,16 +1,29 @@
 package dev.openfeature.contrib.tools.junitopenfeature;
 
-import dev.openfeature.sdk.FlagValueType;
 import org.junit.jupiter.api.extension.ExtendWith;
 
-import java.lang.annotation.*;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Repeatable;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
 
+/**
+ * Annotation for generating an extended configuration for OpenFeature.
+ * This annotation allows you to specify a list of flags for a specific domain.
+ */
 @Target({ ElementType.METHOD, ElementType.TYPE })
 @Retention(RetentionPolicy.RUNTIME)
 @Repeatable(value = OpenFeatures.class)
 @ExtendWith(OpenFeatureExtension.class)
 public @interface OpenFeature {
+    /**
+     * the provider domain used for this configuration.
+     */
     String domain() default "";
+    /**
+     * Collection of {@link Flag} configurations for this domain.
+     */
     Flag[] value();
 }
 

Diff for: tools/junit-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/OpenFeatureDefaultDomain.java

@@ -2,12 +2,21 @@
 
 import org.junit.jupiter.api.extension.ExtendWith;
 
-import java.lang.annotation.*;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
 
+/**
+ * Configuration of a default domain for standalone {@link Flag} configurations.
+ */
 @Target({ElementType.TYPE})
 @Retention(RetentionPolicy.RUNTIME)
 @ExtendWith(OpenFeatureExtension.class)
 public @interface OpenFeatureDefaultDomain {
+    /**
+     * the default domain.
+     */
     String value() default "";
 }
 

Diff for: tools/junit-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/OpenFeatureExtension.java

@@ -5,53 +5,28 @@
 import dev.openfeature.sdk.providers.memory.Flag;
 import dev.openfeature.sdk.providers.memory.InMemoryProvider;
 import org.apache.commons.lang3.BooleanUtils;
-import org.junit.jupiter.api.extension.*;
+import org.junit.jupiter.api.extension.AfterEachCallback;
+import org.junit.jupiter.api.extension.BeforeEachCallback;
+import org.junit.jupiter.api.extension.ExtensionContext;
 import org.junitpioneer.internal.PioneerAnnotationUtils;
 
 import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
 
-public class OpenFeatureExtension implements BeforeEachCallback, AfterEachCallback, ParameterResolver {
+/**
+ * JUnit5 Extension for OpenFeature.
+ */
+public class OpenFeatureExtension implements BeforeEachCallback, AfterEachCallback {
 
     OpenFeatureAPI api = OpenFeatureAPI.getInstance();
 
-
-    @Override
-    public void afterEach(ExtensionContext extensionContext) throws Exception {
-
-        @SuppressWarnings("unchecked") Map<String, Map<String, Flag<?>>> configuration =
-                (Map<String, Map<String, Flag<?>>>) getStore(extensionContext).get("config");
-        for (Map.Entry<String, Map<String, Flag<?>>> stringMapEntry : configuration.entrySet()) {
-            InMemoryProvider inMemoryProvider = new InMemoryProvider(stringMapEntry.getValue());
-            if (stringMapEntry.getKey().isEmpty()) {
-                api.setProvider(new NoOpProvider());
-            } else {
-                api.setProvider(stringMapEntry.getKey(), new NoOpProvider());
-            }
-        }
-    }
-
-
-    @Override
-    public void beforeEach(ExtensionContext extensionContext) throws Exception {
-        Map<String, Map<String, Flag<?>>> configuration = handleSimpleConfiguration(extensionContext);
-        configuration.putAll(handleExtendedConfiguration(extensionContext, configuration));
-
-        for (Map.Entry<String, Map<String, Flag<?>>> stringMapEntry : configuration.entrySet()) {
-            InMemoryProvider inMemoryProvider = new InMemoryProvider(stringMapEntry.getValue());
-            if (stringMapEntry.getKey().isEmpty()) {
-                api.setProvider(inMemoryProvider);
-            } else {
-                api.setProvider(stringMapEntry.getKey(), inMemoryProvider);
-            }
-        }
-
-        getStore(extensionContext).put("config", configuration);
-    }
-
-    private static Map<String, Map<String, Flag<?>>> handleExtendedConfiguration(ExtensionContext extensionContext, Map<String, Map<String, Flag<?>>> configuration) {
-        PioneerAnnotationUtils.findAllEnclosingRepeatableAnnotations(extensionContext, OpenFeature.class)
+    private static Map<String, Map<String, Flag<?>>> handleExtendedConfiguration(
+            ExtensionContext extensionContext,
+            Map<String, Map<String, Flag<?>>> configuration
+    ) {
+        PioneerAnnotationUtils
+                .findAllEnclosingRepeatableAnnotations(extensionContext, OpenFeature.class)
                 .forEachOrdered(annotation -> {
                     Map<String, Flag<?>> domainFlags = configuration.getOrDefault(annotation.domain(), new HashMap<>());
 
@@ -68,10 +43,13 @@ private static Map<String, Map<String, Flag<?>>> handleExtendedConfiguration(Ext
 
     private static Map<String, Map<String, Flag<?>>> handleSimpleConfiguration(ExtensionContext extensionContext) {
         Map<String, Map<String, Flag<?>>> configuration = new HashMap<>();
-        String defaultDomain = PioneerAnnotationUtils.findClosestEnclosingAnnotation(extensionContext, OpenFeatureDefaultDomain.class)
-                .map(OpenFeatureDefaultDomain::value)
-                .orElse("");
-        PioneerAnnotationUtils.findAllEnclosingRepeatableAnnotations(extensionContext, dev.openfeature.contrib.tools.junitopenfeature.Flag.class)
+        String defaultDomain = PioneerAnnotationUtils
+                .findClosestEnclosingAnnotation(extensionContext, OpenFeatureDefaultDomain.class)
+                .map(OpenFeatureDefaultDomain::value).orElse("");
+        PioneerAnnotationUtils
+                .findAllEnclosingRepeatableAnnotations(
+                        extensionContext,
+                        dev.openfeature.contrib.tools.junitopenfeature.Flag.class)
                 .forEachOrdered(flag -> {
                     Map<String, Flag<?>> domainFlags = configuration.getOrDefault(defaultDomain, new HashMap<>());
                     if (!domainFlags.containsKey(flag.name())) {
@@ -103,13 +81,34 @@ private static Flag.FlagBuilder<?> generateFlagBuilder(dev.openfeature.contrib.t
     }
 
     @Override
-    public boolean supportsParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException {
-        return false;
+    public void afterEach(ExtensionContext extensionContext) throws Exception {
+
+        @SuppressWarnings("unchecked") Map<String, Map<String, Flag<?>>> configuration =
+                (Map<String, Map<String, Flag<?>>>) getStore(extensionContext).get("config");
+        for (Map.Entry<String, Map<String, Flag<?>>> stringMapEntry : configuration.entrySet()) {
+            if (stringMapEntry.getKey().isEmpty()) {
+                api.setProvider(new NoOpProvider());
+            } else {
+                api.setProvider(stringMapEntry.getKey(), new NoOpProvider());
+            }
+        }
     }
 
     @Override
-    public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext) throws ParameterResolutionException {
-        return null;
+    public void beforeEach(ExtensionContext extensionContext) throws Exception {
+        Map<String, Map<String, Flag<?>>> configuration = handleSimpleConfiguration(extensionContext);
+        configuration.putAll(handleExtendedConfiguration(extensionContext, configuration));
+
+        for (Map.Entry<String, Map<String, Flag<?>>> stringMapEntry : configuration.entrySet()) {
+            InMemoryProvider inMemoryProvider = new InMemoryProvider(stringMapEntry.getValue());
+            if (stringMapEntry.getKey().isEmpty()) {
+                api.setProvider(inMemoryProvider);
+            } else {
+                api.setProvider(stringMapEntry.getKey(), inMemoryProvider);
+            }
+        }
+
+        getStore(extensionContext).put("config", configuration);
     }
 
     private ExtensionContext.Store getStore(ExtensionContext context) {

Diff for: tools/junit-openfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/OpenFeatures.java

@@ -2,12 +2,21 @@
 
 import org.junit.jupiter.api.extension.ExtendWith;
 
-import java.lang.annotation.*;
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
 
-@Target({ ElementType.METHOD, ElementType.TYPE })
+/**
+ * Collection of {@link OpenFeature} configurations.
+ */
+@Target({ElementType.METHOD, ElementType.TYPE})
 @Retention(RetentionPolicy.RUNTIME)
 @ExtendWith(OpenFeatureExtension.class)
 public @interface OpenFeatures {
+    /**
+     * Collection of {@link OpenFeature} configurations.
+     */
     OpenFeature[] value() default {};
 }