lint fixes

Signed-off-by: Kavindu Dodanduwa <[email protected]>

Author: Kavindu-Dodan

checkstyle-suppressions.xml

@@ -5,4 +5,7 @@
 <suppressions>
     <!-- don't check style of generated sources (GRPC bindings) -->
     <suppress files="[\\/]generated-sources[\\/]" checks="[a-zA-Z0-9]*" />
+
+    <!-- ignore Murmur3 implementation -->
+    <suppress files="[Murmur3]" checks="[a-zA-Z0-9]*" />
 </suppressions>

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java

@@ -40,13 +40,13 @@ public class FlagParser {
     private static JsonSchema SCHEMA_VALIDATOR;
 
     static {
-        try( final InputStream schema = FlagParser.class.getClassLoader().getResourceAsStream(SCHEMA_RESOURCE)) {
+        try (final InputStream schema = FlagParser.class.getClassLoader().getResourceAsStream(SCHEMA_RESOURCE)) {
             if (schema == null) {
                 log.log(Level.WARNING, String.format("Resource %s not found", SCHEMA_RESOURCE));
             } else {
                 final ByteArrayOutputStream result = new ByteArrayOutputStream();
                 byte[] buffer = new byte[512];
-                for (int size; 0 <(size = schema.read(buffer));){
+                for (int size; 0 < (size = schema.read(buffer)); ) {
                     result.write(buffer, 0, size);
                 }
 

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/Operator.java

@@ -13,8 +13,8 @@
  */
 public class Operator {
 
-    final static String FLAG_KEY = "$flagKey";
-    final static String TARGET_KEY = "targetingKey";
+    static final String FLAG_KEY = "$flagKey";
+    static final String TARGET_KEY = "targetingKey";
 
     private final JsonLogic jsonLogicHandler;
 
@@ -29,6 +29,9 @@ public Operator() {
         jsonLogicHandler.addOperation(new StringComp(StringComp.Type.ENDS_WITH));
     }
 
+    /**
+     * Apply this operator on the provided rule.
+     */
     public Object apply(final String flagKey, final String targetingRule, final EvaluationContext ctx)
             throws TargetingRuleException {
         final Map<String, Object> valueMap = ctx.asObjectMap();
@@ -50,18 +53,18 @@ static class FlagProperties {
             if (from instanceof Map) {
                 Map<?, ?> dataMap = (Map<?, ?>) from;
 
-                Object fKey = dataMap.get(FLAG_KEY);
+                Object flagKey = dataMap.get(FLAG_KEY);
 
-                if (fKey instanceof String) {
-                    flagKey = (String) fKey;
+                if (flagKey instanceof String) {
+                    this.flagKey = (String) flagKey;
                 } else {
-                    flagKey = null;
+                    this.flagKey = null;
                 }
 
-                Object tKey = dataMap.get(TARGET_KEY);
+                Object targetKey = dataMap.get(TARGET_KEY);
 
-                if (tKey instanceof String) {
-                    targetingKey = (String) tKey;
+                if (targetKey instanceof String) {
+                    targetingKey = (String) targetKey;
                 } else {
                     targetingKey = null;
                 }

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/targeting/TargetingRuleException.java

@@ -1,8 +1,14 @@
 package dev.openfeature.contrib.providers.flagd.resolver.process.targeting;
 
-public class TargetingRuleException extends Exception{
+/**
+ * Exception used by targeting rule package.
+ **/
+public class TargetingRuleException extends Exception {
 
-    public TargetingRuleException(final String message, final Throwable t){
+    /**
+     * Construct exception.
+     **/
+    public TargetingRuleException(final String message, final Throwable t) {
         super(message, t);
     }
 }

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParserTest.java

@@ -46,7 +46,8 @@ public void validJsonConfigurationWithTargetingRulesParsing() throws IOException
         assertEquals("loop", variants.get("loop"));
         assertEquals("binet", variants.get("binet"));
 
-        assertEquals("{\"if\":[{\"in\":[\"@faas.com\",{\"var\":[\"email\"]}]},\"binet\",null]}", stringFlag.getTargeting());
+        assertEquals("{\"if\":[{\"in\":[\"@faas.com\",{\"var\":[\"email\"]}]},\"binet\",null]}",
+                stringFlag.getTargeting());
     }