feat!: update to sdk 0.3.0 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
feat/update-sdk
branch
2 times, most recently
from
a0f13c1 to
aa4e226
Compare
|
@thomaspoignant please take a look at the goff changes. Similar to Node, they are mostly about reason/error code. If this doesn't make sense, let me know, or push changes! Note: this is to absorb the UNRELEASED Java changes. |
toddbaert
commented
Oct 6, 2022
| @@ -215,8 +218,7 @@ private <T> ProviderEvaluation<T> resolveEvaluationGoFeatureFlagProxy( | |||
| } | |||
|
|
|||
| return ProviderEvaluation.<T>builder() | |||
| .errorCode(goffResp.getErrorCode()) | |||
There was a problem hiding this comment.
I removed the error code here. I think that if we got this far, we don't need the error? Otherwise we should probably throw.
I think this is the biggest GOFF change I made.
toddbaert
force-pushed
the
feat/update-sdk
branch
from
aa4e226 to
a8ae38c
Compare
toddbaert
force-pushed
the
feat/update-sdk
branch
from
a8ae38c to
3a5aa8b
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/update-sdk
branch
from
3a5aa8b to
c763aeb
Compare
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Oct 13, 2022
Comment on lines
-162
to
-170
| // Map FlagD reasons to Java SDK reasons. | ||
| private Reason mapReason(String flagdReason) { | ||
| if (!EnumUtils.isValidEnum(Reason.class, flagdReason)) { | ||
| return Reason.UNKNOWN; | ||
| } else { | ||
| return Reason.valueOf(flagdReason); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
reasons are strings now.
beeme1mr
approved these changes
Oct 13, 2022
thomaspoignant
approved these changes
Oct 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absorbs most recent SDK changes. Pretty easy changes for the most part.