Skip to content

chore: adjust noisy log lines #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

chore: adjust noisy log lines #1268

merged 3 commits into from
Mar 10, 2025

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Mar 7, 2025

Just tweaking some log lines.

My opinion is:

  • anything log lines that are "normal" (expected at runtime) should be debug
    • stream ending (this is normal with deadlines)
    • change notifications
  • startup/shutdown messages are OK at info
  • unexpected errors (like disconnections) should be error
  • "weird things" that should never happen, but aren't catastrophic should be warn.

@toddbaert toddbaert merged commit 0a81a14 into main Mar 10, 2025
5 checks passed
@toddbaert toddbaert deleted the chore/clean-up-logs branch March 10, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants