Skip to content

chore: log tweaks, retry cancels, add options.toBuidler #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

toddbaert
Copy link
Member

Minor logging tweaks, also retrying on CANCELLED.

@toddbaert toddbaert force-pushed the chore/loging-and-minor-retry-tweaks branch 2 times, most recently from 3b7c908 to dd87d38 Compare March 13, 2025 19:11
@toddbaert toddbaert changed the title chore: add error log on stream fail, retry cancels fix: add error log on stream fail, retry cancels, use context Mar 13, 2025
@toddbaert toddbaert marked this pull request as draft March 13, 2025 19:23
@toddbaert toddbaert changed the title fix: add error log on stream fail, retry cancels, use context chore: error log on stream fail, retry cancels, 5000ms default deadline Mar 13, 2025
@toddbaert toddbaert force-pushed the chore/loging-and-minor-retry-tweaks branch from dd87d38 to dded17d Compare March 13, 2025 20:16
@toddbaert toddbaert marked this pull request as ready for review March 13, 2025 20:16
@toddbaert toddbaert requested a review from aepfli March 13, 2025 20:17
@toddbaert toddbaert force-pushed the chore/loging-and-minor-retry-tweaks branch from dded17d to ce23fc9 Compare March 13, 2025 20:29
@toddbaert toddbaert changed the title chore: error log on stream fail, retry cancels, 5000ms default deadline chore: error log on stream fail, retry cancels Mar 13, 2025
@toddbaert toddbaert changed the title chore: error log on stream fail, retry cancels chore: log tweaks, retry cancels, add options.toBuidler Mar 18, 2025
@toddbaert toddbaert force-pushed the chore/loging-and-minor-retry-tweaks branch from 1205f6a to 7bf97ff Compare March 18, 2025 19:03
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert force-pushed the chore/loging-and-minor-retry-tweaks branch from b8c8972 to 8ecb359 Compare March 18, 2025 19:21
@toddbaert toddbaert merged commit fde9e39 into main Mar 18, 2025
5 checks passed
@toddbaert toddbaert deleted the chore/loging-and-minor-retry-tweaks branch March 18, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants