fix: graceful flagsmith provider shutdown #1305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul <[email protected]>
paulhobbel
changed the title
aepfli
approved these changes
Apr 14, 2025
|
Hmm I see some tests of the |
chrfwow
approved these changes
Apr 14, 2025
beeme1mr
approved these changes
Apr 14, 2025
|
The Flagsmith tests are passing. I'm going to merge this PR since the failing flagd tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Properly close the
FlagsmithClienton shutdown of the provider to support graceful shutdown of OpenFeature.Related Issues
Fixes #1304
Notes
Follow-up Tasks
How to test