Skip to content

feat: flagd in-process evalator improvements #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kavindu-Dodan
Copy link
Collaborator

This PR

Improves in-process evaluator with,

  • Adding selector field for gRPC sync connection 1
  • Allow unknown fields in flagd flag structure: future-proofing when flag sources change

Footnotes

  1. https://github.com/open-feature/schemas/blob/main/protobuf/sync/v1/sync_service.proto#L24

Signed-off-by: Kavindu Dodanduwa <[email protected]>
@toddbaert
Copy link
Member

Allow unknown fields in flagd flag structure: future-proofing when flag sources change

Probably a good idea.

Signed-off-by: Kavindu Dodanduwa <[email protected]>
@Kavindu-Dodan Kavindu-Dodan force-pushed the feat/improve-in-process-provider branch from 5eed9e6 to d46dc26 Compare September 22, 2023 21:03
@Kavindu-Dodan Kavindu-Dodan merged commit a96c5d8 into open-feature:main Sep 22, 2023
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…ure#451)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants