feat: flagd file polling for offline mode #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
force-pushed
the
feat/flagd-file-poll
branch
from
1f11f07 to
acd5ab9
Compare
thisthat
reviewed
Jan 5, 2024
...enfeature/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnector.java
Show resolved
Hide resolved
...ature/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnectorTest.java
Outdated
Show resolved
Hide resolved
Kavindu-Dodan
force-pushed
the
feat/flagd-file-poll
branch
9 times, most recently
from
1d7d45c to
60d389e
Compare
thisthat
approved these changes
Jan 8, 2024
toddbaert
reviewed
Jan 8, 2024
...enfeature/contrib/providers/flagd/resolver/process/storage/connector/file/FileConnector.java
Show resolved
Hide resolved
toddbaert
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Approving with this question. I will let you consider it and decide if you think it's something we should worry about in this PR.
Thanks for the review. Regarding the concurrency concern, I will address it in a dedicated PR. As described here only possibility for concurrent issues is if the same provider get registered multiple times (which is allowed in spec). And I think we need to check this edge case in other lang. implementations as well. |
This was referenced Jan 9, 2024
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
force-pushed
the
feat/flagd-file-poll
branch
from
5bd774d to
014c940
Compare
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…ature#614) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Enhance flagd in-process offline mode introduced through #473 by adding polling support and align with the change proposed at flagd js-sdk (open-feature/js-sdk-contrib#708)
Polling happens at intervals of 5 seconds and runs concurrently. If an update is observed, connect offers the newest content to the storage through the connector contract.
Note on polling
The reason to use polling is the known limitation of Java WatchService when it comes to non-local file systems. This blog post 1 extensively describes the problem. Besides, the offline mode is intended for limited use cases such as testing, local development efforts or POC deployments where the impact of polling is minimal.
Footnotes
https://blog.arkey.fr/2019/09/13/watchservice-and-bind-mount/ ↩